Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[modeline] Add segments to future drop global-mode-string #3188

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ericdallo
Copy link
Member

@ericdallo ericdallo commented Nov 5, 2021

Fixes #2571

This PR adds 2 new variables:

  • lsp-modeline-use-global-mode-string with t as default which behaves the same as ATM, adding modeling strings to the global-mode-string.
  • lsp-modeline-segments used in case lsp-modeline-use-global-mode-string is nil, indicating the modeling segments features and its order, adding those segments in the mode-line-format before major modes following the same evil-mode does.

This should standardize the way we add things to modeling and make it easy to improve fixing spacing and other things.

To disable lsp-modeline-use-global-mode-string by default, we should at least update major modelines like doom-emacs modeline, doom-modeline, spaceemacs (?) to use the lsp-modeline--string in their modeling.

How it looks on my modeline:
image

@ericdallo ericdallo added the core label Nov 5, 2021
@ericdallo ericdallo self-assigned this Nov 5, 2021
@ericdallo ericdallo added this to Review in lsp-mode via automation Nov 5, 2021
@ericdallo ericdallo added this to the Next release milestone Nov 5, 2021
@ericdallo
Copy link
Member Author

c/c @yyoncho @alanz @kiennq

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
lsp-mode
  
Review
Development

Successfully merging this pull request may close these issues.

Feature Request: re-arrange mode line order
1 participant