Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Require TRAMP from ob-jupyter #271

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

johnbcoughlin
Copy link

Fixes #261

@link0ff
Copy link

link0ff commented Nov 14, 2020

But this will load the whole TRAMP package even when the user has no intention to use commands that require TRAMP functions. A nicer thing would be to ask TRAMP developers to add an ###autoload tag to the function tramp-tramp-file-p. But it would take much time until a new TRAMP version will be released. So maybe a better thing to do now would be to add something like this instead of (require 'tramp) in ob-jupyter.el:

(autoload 'tramp-tramp-file-p "tramp" "Return t if NAME is a string with Tramp file name syntax." nil nil)

@johnbcoughlin johnbcoughlin deleted the ob-jupyter-require-tramp branch July 3, 2021 14:12
@johnbcoughlin johnbcoughlin restored the ob-jupyter-require-tramp branch July 3, 2021 14:18
@johnbcoughlin johnbcoughlin reopened this Jul 3, 2021
@johnbcoughlin
Copy link
Author

Thank you, that's a good point. Updated to use your suggestion.

@nnicandro
Copy link
Collaborator

Shouldn't we have the autoload somewhere closer to jupyter-tramp-file-name-p? For example somewhere in jupyter-tramp.el. Why does it need to be in ob-jupyter.el? The problem doesn't really have anything to do with Org.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

tramp-tramp-file-p function void
3 participants