DO NOT MERGE: Update Julia REPL latex completion for upcoming changes #201
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I see now that there's logic to complete argument lists and symbols used as dictionary keys, so this PR is incorrect in what it removes. Will update when I get a chance. EDIT: Done, I think. |
non-Jedi
force-pushed
the
julia-latexsub-completion
branch
from
47d4d30
to
9b05f7e
Compare
non-Jedi
force-pushed
the
julia-latexsub-completion
branch
from
9b05f7e
to
918d9f0
Compare
|
Is this PR finished? If so, you may want to change the title. |
|
@MasonProtter No. It's just a preemptive PR for when/if julia-mode is updated with JuliaEditorSupport/julia-emacs#82, and it isn't working correctly anyways. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Recently made a PR to julia-mode to use
completion-at-pointfor latex substitution: JuliaEditorSupport/julia-emacs#82. This PR is the changes necessary for compatibility with that new implementation.I didn't quite grok how
jupyter-completion-at-pointworked, so there may be details I'm missing, but from what I can tell, it's just duplicating the behavior ofjulia-latexsub-completion-at-point. Let me know if I'm missing something.I'm just making this PR now so that I don't forget to do so later since I'm using this branch locally.
I did not update the README which uses
jupyter-indent-lineas defined for julia as an example because I didn't know what would be a good example to replace it with. There's also the question of whetherjupyter-indent-lineis worth maintaining since it was only used for julia.