Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix windows script update #48

Merged
merged 3 commits into from
Jul 11, 2021

Conversation

juergenhoetzel
Copy link
Contributor

@juergenhoetzel juergenhoetzel commented Jul 9, 2021

This is really an obscure issue. Fixes:

             Cannot locate installed script `eldev.ps1', skipping
             Cannot locate installed script `eldev.bat', skipping

and

[00:14.519]  Stdout contents:
             Upgraded or installed 1 package
             Upgraded script `c:/Users/PIDSLE~1/AppData/Local/Temp/eldev-xoazUY-test-bin/bin/eldev.ps1'
             Upgraded script `c:/Users/PIDSLE~1/AppData/Local/Temp/eldev-xoazUY-test-bin/bin/eldev.bat'

[00:14.530]  Stderr contents:
             [1/1] Upgrading package `eldev' (0.9.2snapshot -> 999.9) from `bootstrap-pa'...
             Der Befehl "--" ist entweder falsch geschrieben oder
             konnte nicht gefunden werden.

Appending the "rem" comment instead of prepending fixes the issue.

Running a .bat script while it is updating itself seems to lead to obscure errors as listed above.

@juergenhoetzel juergenhoetzel force-pushed the fix-windows-script-update branch 3 times, most recently from 87dbc8a to fc12dde Compare July 9, 2021 19:17
@juergenhoetzel juergenhoetzel force-pushed the fix-windows-script-update branch from fc12dde to 4afd71c Compare July 9, 2021 19:40
@doublep
Copy link
Collaborator

doublep commented Jul 11, 2021

Thank you! Using file-name-base instead of file-name-nondirectory was really my mistake, I just never noticed since on non-Windows the file is called without extension, so they both give the same result in that specific case. But some other things I wouldn't be able to catch without access to Windows at all.

@doublep doublep merged commit e035888 into emacs-eldev:master Jul 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants