Use javascript-action instead of platform dependent Shell commands #36
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change allows to execute github installation test in a platform-agnostic way (required to merge #35 by @ikappak)
Instead of a simple "test -x eldev" test,
eldev
is actuallybootstrapped again to verify that the net-installation was indeed
successful.
The previous
shell
tests also use the hardcoded pathhttps://raw.github.com/doublep/eldev/master/bin/eldev to download the
eldev scripts. So CI will not test changes introduced in the PRs.
The utility function
getRawUrl
generates the correct raw downloadURL depending on the context (pushing to master or PR) and also adds a
platform dependent suffix (.bat on Windows) to the script name to make
the script download/testing platform-agnostic.