Skip to content

Commit

Permalink
Experimentally run `eldev doctor' during CI.
Browse files Browse the repository at this point in the history
  • Loading branch information
doublep committed Jun 1, 2023
1 parent edac37c commit ab5c7a9
Showing 1 changed file with 9 additions and 0 deletions.
9 changes: 9 additions & 0 deletions .github/workflows/test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -89,6 +89,15 @@ jobs:
env:
ELDEV_LOCAL: "."

- name: Doctor the project
run: |
# Run `doctor' on the project itself. Git hooks are not going
# to be installed in this checkout. Also, don't insist on
# recent stable releases here.
./bin/eldev -p -dtTC doctor -- -githooks -recent-stable-releases
env:
ELDEV_LOCAL: "."

# Method 1: if you have a catch-all directory for executables. We
# don't test bootstrapping, as that is supposed to have been
# tested by normal ERT tests.
Expand Down

2 comments on commit ab5c7a9

@doublep
Copy link
Collaborator Author

@doublep doublep commented on ab5c7a9 Jun 2, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ikappaki, @juergenhoetzel: can anyone of you please have a look at this Windows-only failure, see e.g. here: https://github.com/doublep/eldev/actions/runs/5158910006/jobs/9293347032

Looks like Eldev doesn't handle -- in the command line on Windows, but I don't understand why. This should be handled already at Elisp level, see eldev-parse-options. Something might go fishy in eldev.bat.in, but as far as I can read it, it should behave similarly to the "standard" Linux script, which has no problem with this...

If any of you investigates this, please write a comment to avoid job duplication. Thank you.

@ikappaki
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @doublep,

it's most probably due to the the double dash being a special operator in PowerShell and have to be escaped as such, as per https://stackoverflow.com/questions/15780174/powershell-command-line-parameters-and.

Patch incoming, assuming double quoting does not have side effects on the other platforms.

Thanks

Please sign in to comment.