Don't throw out field data; use cache for citeproc #742
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Can you take a look at this @andras-simonyi @andersjohansson?
It's a simple solution to the problem we've previously discussed, and an alternative to #710. I mostly stole code from
org-cite-csl-activate
!But this should:
citar-copy-reference
slow? #702org-cite-csl-activate
README.The only problem I can potentially see is maybe it slows down initial loading of libraries a little, and uses a bit more memory. But I doubt it's a significant impact. And if it ever were, we could always add a defcustom so people could turn it off?
@andras-simonyi - not sure what you think about this, but one possibility is you can use the functions here instead, since you're already loading
citar
when available, and remove some code inorg-cite-csl-activate
in the process?cc @benthamite