Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

citar-key-finder should return key string by default #642

Closed
bdarcus opened this issue Jun 22, 2022 · 0 comments · Fixed by #634
Closed

citar-key-finder should return key string by default #642

bdarcus opened this issue Jun 22, 2022 · 0 comments · Fixed by #634
Labels
enhancement New feature or request

Comments

@bdarcus
Copy link
Contributor

bdarcus commented Jun 22, 2022

Right now, this function returns a target cons that is only useful in Embark.

Perhaps we should tweak things a bit, so we have:

  1. citar--key-finder (this is the current function renamed)
  2. citar-embark-key-finder (assuming Move embark code to a separate package #643, this is purely an alias for 1)
  3. citar-key-finder (this just returns the key from 1)

So:

(defun citar-key-finder ()
  "Return key-at-point as string."
  (cadr (citar--key-finder)))

(defalias 'citar-embark-key-finder #'citar--key-finder
  "Return key-at-point target for Embark.")
@bdarcus bdarcus added the enhancement New feature or request label Jun 22, 2022
bdarcus added a commit to roshanshariff/citar that referenced this issue Jun 23, 2022
roshanshariff added a commit to roshanshariff/citar that referenced this issue Jun 24, 2022
@bdarcus bdarcus linked a pull request Jun 26, 2022 that will close this issue
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant