citar-file--possible-names broke

[bdarcus]

Something isn't working correctly with this function now, which has cascading impacts (for example, open-notes now doesn't work correctly). It now only returns existing files, but should always return a list of paths.

ELISP> (citar-file--possible-names "low2001" citar-notes-paths '("org"))
("/home/bruce/org/roam/biblio/low2001.org")
ELISP> (citar-file--possible-names "low200X1" citar-notes-paths '("org"))
nil

cc @localauthor @roshanshariff

[bdarcus]

The problem appears to be here; #413 should fix it, though I haven't tested it extensively.

[bdarcus]

OK @massdorp, I merged a fix. Can you test and confirm?

[maasdorp]

Thank you! Now it works as intended once again. I could create a new note from the template using citar-open-notes.

[roshanshariff]

Yes, sorry, my mistake. I hadn't realized how that function is used for creating new notes as well.

[bdarcus]

No worries; I should have caught that.