Skip to content

Remove useless test covered elsewhere #166

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
elzik merged 1 commit into from
Oct 25, 2025
Merged

Remove useless test covered elsewhere #166

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 0 additions & 23 deletions ...Elzik.Breef.Infrastructure.Tests.Unit/ContentExtractors/Reddit/SubRedditExtractorTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -282,29 +282,6 @@ public async Task GetSubredditImageUrlAsync_ImageKeyExistsAndIsAccessible_Return
result.ShouldBe(imageUrl);
}

[Theory]
[InlineData("programming")]
[InlineData("learnprogramming")]
[InlineData("AskReddit")]
[InlineData("funny")]
public async Task GetSubredditImageUrlAsync_ValidSubredditName_CallsCorrectAboutUrl(string subredditName)
{
// Arrange
var expectedUrl = $"https://www.reddit.com/r/{subredditName}/about.json";
var json = JsonSerializer.Serialize(new { data = new { } });

var mockHandler = new MockHttpMessageHandler(json, System.Net.HttpStatusCode.OK);
var httpClient = new HttpClient(mockHandler);
_mockHttpClientFactory.CreateClient("BreefDownloader").Returns(httpClient);

// Act
await _extractor.GetSubredditImageUrlAsync(subredditName);

// Assert
// Since we're using MockHttpMessageHandler, we can't easily verify the exact URL called
// The test passes if no exception is thrown and the method completes successfully
}

[Fact]
public async Task GetSubredditImageUrlAsync_NoImageKeysExist_ReturnsFallbackImageUrl()
{
Expand Down
Loading