-
-
Notifications
You must be signed in to change notification settings - Fork 505
Handle Range header for File/Blob responses #1802
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+178
−33
Merged
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,82 @@ | ||
| import { describe, expect, it } from 'bun:test' | ||
|
|
||
| import { Elysia } from '../../src' | ||
| import { req } from '../utils' | ||
|
|
||
| // Regression test for https://github.com/elysiajs/elysia/issues/1790 | ||
| // Range header was ignored; always returned bytes 0-N/N instead of the requested slice. | ||
| describe('Range header', () => { | ||
| const content = '12345' | ||
| const app = new Elysia().get('/file', () => new Blob([content])) | ||
|
|
||
| it('returns full file without Range header', async () => { | ||
| const res = await app.handle(req('/file')) | ||
| expect(res.status).toBe(200) | ||
| expect(await res.text()).toBe(content) | ||
| }) | ||
|
|
||
| it('handles bytes=start- (open-ended range)', async () => { | ||
| const res = await app.handle( | ||
| req('/file', { headers: { range: 'bytes=3-' } }) | ||
| ) | ||
| expect(res.status).toBe(206) | ||
| expect(res.headers.get('content-range')).toBe('bytes 3-4/5') | ||
| expect(res.headers.get('content-length')).toBe('2') | ||
| expect(await res.text()).toBe('45') | ||
| }) | ||
|
|
||
| it('handles bytes=start-end (bounded range)', async () => { | ||
| const res = await app.handle( | ||
| req('/file', { headers: { range: 'bytes=1-3' } }) | ||
| ) | ||
| expect(res.status).toBe(206) | ||
| expect(res.headers.get('content-range')).toBe('bytes 1-3/5') | ||
| expect(res.headers.get('content-length')).toBe('3') | ||
| expect(await res.text()).toBe('234') | ||
| }) | ||
|
|
||
| it('handles bytes=-suffix (last N bytes)', async () => { | ||
| const res = await app.handle( | ||
| req('/file', { headers: { range: 'bytes=-2' } }) | ||
| ) | ||
| expect(res.status).toBe(206) | ||
| expect(res.headers.get('content-range')).toBe('bytes 3-4/5') | ||
| expect(res.headers.get('content-length')).toBe('2') | ||
| expect(await res.text()).toBe('45') | ||
| }) | ||
|
|
||
| it('clamps end beyond file size to last byte', async () => { | ||
| const res = await app.handle( | ||
| req('/file', { headers: { range: 'bytes=2-999' } }) | ||
| ) | ||
| expect(res.status).toBe(206) | ||
| expect(res.headers.get('content-range')).toBe('bytes 2-4/5') | ||
| expect(await res.text()).toBe('345') | ||
| }) | ||
|
|
||
| it('returns 416 when start is out of range', async () => { | ||
| const res = await app.handle( | ||
| req('/file', { headers: { range: 'bytes=99-' } }) | ||
| ) | ||
| expect(res.status).toBe(416) | ||
| expect(res.headers.get('content-range')).toBe('bytes */5') | ||
| }) | ||
|
|
||
| it('returns 416 for invalid "bytes=-" (both positions empty)', async () => { | ||
| const res = await app.handle( | ||
| req('/file', { headers: { range: 'bytes=-' } }) | ||
| ) | ||
| expect(res.status).toBe(416) | ||
| expect(res.headers.get('content-range')).toBe('bytes */5') | ||
| }) | ||
|
|
||
| it('ignores subsequent ranges in multi-range requests, uses first range only', async () => { | ||
| // Multi-range (e.g. bytes=0-1,3-4) is not supported; only the first range is applied. | ||
| const res = await app.handle( | ||
| req('/file', { headers: { range: 'bytes=0-1,3-4' } }) | ||
| ) | ||
| expect(res.status).toBe(206) | ||
| expect(res.headers.get('content-range')).toBe('bytes 0-1/5') | ||
| expect(await res.text()).toBe('12') | ||
| }) | ||
| }) |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.