Skip to content

Invert password verification condition in Best Practice page #770

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
SaltyAom merged 1 commit into from
Jan 23, 2026
Merged

Invert password verification condition in Best Practice page #770

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion docs/essential/best-practice.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,7 +95,7 @@ export abstract class Auth {
WHERE username = ${username}
LIMIT 1`

if (await Bun.password.verify(password, user.password))
if (!await Bun.password.verify(password, user.password))
Copy link
Contributor

@coderabbitai coderabbitai bot Dec 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟡 Minor

Fix hard tab indentation; use spaces instead.

The indentation on this line uses hard tabs, which violates the Markdown linting rule MD010. Replace with spaces for consistency with Markdown best practices.

🔎 Proposed fix: Replace hard tab with spaces 
-		if (!await Bun.password.verify(password, user.password))
+		if (!await Bun.password.verify(password, user.password))

(Replace the leading hard tab with two levels of space indentation to match the surrounding code block formatting.)

📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
if (!await Bun.password.verify(password, user.password))
if (!await Bun.password.verify(password, user.password))
🧰 Tools
🪛 markdownlint-cli2 (0.18.1)

98-98: Hard tabs
Column: 1

(MD010, no-hard-tabs)

🤖 Prompt for AI Agents 
In docs/essential/best-practice.md around line 98, the line "if (!await
Bun.password.verify(password, user.password))" is indented with a hard tab which
violates MD010; replace the leading hard tab with spaces (use two-level space
indentation to match the surrounding fenced code block) so the line uses only
spaces for indentation and aligns with neighboring lines.

// You can throw an HTTP error directly
throw status(
400,
Expand Down