-
Notifications
You must be signed in to change notification settings - Fork 469
Update descriptions on comparisons to reflect actual pages :> #769
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
WalkthroughCorrected text and indentation for four comparison Card entries in Changes
Estimated Code Review Effort🎯 1 (Trivial) | ⏱️ ~2 minutes Possibly related PRs
Poem
Pre-merge checks and finishing touches✅ Passed checks (3 passed)
✨ Finishing touches🧪 Generate unit tests (beta)
📜 Recent review detailsConfiguration used: Organization UI Review profile: CHILL Plan: Pro 📒 Files selected for processing (1)
🔇 Additional comments (1)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
docs/table-of-content.md (1)
81-93: Approve content changes; fix hard tabs in indentation.The comparison descriptions have been correctly updated to match their respective framework cards (Express and Hono). However, static analysis flagged hard tabs in the indentation of the changed lines (82, 88) and adjacent lines. Replace tabs with spaces to maintain consistent formatting per the markdownlint MD010 rule.
🔎 Proposed fix for hard tabs
<Card title="From Express" href="/migrate/from-express"> - Comparison between Express and Elysia + Comparison between Express and Elysia </Card> <Card title="From Fastify" href="/migrate/from-fastify"> - Comparison between Fastify and Elysia + Comparison between Fastify and Elysia </Card> <Card title="From Hono" href="/migrate/from-hono"> - Comparison between Hono and Elysia + Comparison between Hono and Elysia </Card>Replace all hard tabs with spaces to align with markdownlint rules (MD010).
📜 Review details
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
docs/table-of-content.md
🧰 Additional context used
🪛 markdownlint-cli2 (0.18.1)
docs/table-of-content.md
82-82: Hard tabs
Column: 1
(MD010, no-hard-tabs)
83-83: Hard tabs
Column: 1
(MD010, no-hard-tabs)
85-85: Hard tabs
Column: 3
(MD010, no-hard-tabs)
88-88: Hard tabs
Column: 3
(MD010, no-hard-tabs)
Hey! I noticed that the comparison descriptions were incorrect so I updated them to reflect the actual pages.
Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.