Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use GatewayKernelManager from Jupyter Server when gateway is enabled #1655

Merged
merged 1 commit into from
May 11, 2021

Conversation

kevin-bates
Copy link
Member

@kevin-bates kevin-bates commented May 11, 2021

I recently integrated HTTPKernelManager (and HTTPKernelClient) from Elyra into Jupyter Server as GatewayKernelManager (and GatewayKernelClient) via this pull request that was recently released in Jupyter Server 1.7.0. This pull request replaces our use of HTTPKernelManager/Client with GatewayKernelManager/Client.

How was this pull request tested?

I built the master branch of Elyra and targetted an Enterprise Gateway server with a local pipeline - confirming Elyra and EG integration was working using HTTPKernelManager. I then applied these changes and re-confirmed the local pipeline still completed successfully and the logs (on both servers) reflected the expected results.

Resolves #1649

Developer's Certificate of Origin 1.1

   By making a contribution to this project, I certify that:

   (a) The contribution was created in whole or in part by me and I
       have the right to submit it under the Apache License 2.0; or

   (b) The contribution is based upon previous work that, to the best
       of my knowledge, is covered under an appropriate open source
       license and I have the right under that license to submit that
       work with modifications, whether created in whole or in part
       by me, under the same open source license (unless I am
       permitted to submit under a different license), as indicated
       in the file; or

   (c) The contribution was provided directly to me by some other
       person who certified (a), (b) or (c) and I have not modified
       it.

   (d) I understand and agree that this project and the contribution
       are public and that a record of the contribution (including all
       personal information I submit with it, including my sign-off) is
       maintained indefinitely and may be redistributed consistent with
       this project or the open source license(s) involved.

@elyra-bot
Copy link

elyra-bot bot commented May 11, 2021

Thanks for making a pull request to Elyra!

To try out this branch on binder, follow this link: Binder

@akchinSTC akchinSTC added this to the 2.3.0.beta2 milestone May 11, 2021
@lresende
Copy link
Member

Always good to see less code and enhanced functionality !!!

@lresende lresende merged commit a8cda37 into elyra-ai:master May 11, 2021
@kevin-bates kevin-bates deleted the replace-http-km branch September 11, 2021 23:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Replace HTTPKernelManager/Client with GatewayKernelManager/Client
3 participants