-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#1772 Replace React-hot-loader with React-fast-refresh #1773
#1772 Replace React-hot-loader with React-fast-refresh #1773
Conversation
Signed-off-by: srikant <[email protected]>
Reference: gaearon/react-hot-loader#1227 (comment) |
This change works fine when I have But when I make a change in |
Signed-off-by: srikant <[email protected]>
Signed-off-by: srikant <[email protected]>
Signed-off-by: srikant <[email protected]>
Hi @nmgokhale could you please verify latest changes to this PR in your local. I have replaced react-hot-loader with react-fast-refresh package. These changes are working fine for me on dev local for .jsx and .scss changes. |
Signed-off-by: srikant <[email protected]>
canvas_modules/harness/package.json
Outdated
@@ -73,7 +74,7 @@ | |||
"react-inlinesvg": "4.1.3", | |||
"react-intl": "6.6.3", | |||
"react-redux": "7.2.8", | |||
"react-refresh": "0.14.0", | |||
"react-refresh": "^0.14.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Any reason you're adding ^ to the versions? I think most if not all these should be static versions.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @matthoward366 It got added when I ran npm install -D @pmmmwh/react-refresh-webpack-plugin react-refresh
now I have reverted it.
Signed-off-by: srikant <[email protected]>
canvas_modules/harness/package.json
Outdated
@@ -38,6 +38,7 @@ | |||
"@carbon/charts-react": "1.15.3", | |||
"@carbon/react": "^1.52.0", | |||
"@elyra/canvas": "file:../common-canvas", | |||
"@pmmmwh/react-refresh-webpack-plugin": "^0.5.11", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove react-hot-loader
from package.json and pin this dependency as well.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @nmgokhale I have removed react-hot-loader package and pinned react-refresh-webpack-plugin in package.json, please review.
…lugin in harness package.json Signed-off-by: srikant <[email protected]>
Fixes: #1772
Developer's Certificate of Origin 1.1