-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#1646 Panel accordions are not using the carbon standards #1648
Merged
matthoward366
merged 26 commits into
elyra-ai:main
from
srikant-ch5:14295_Accordion_RightFlyoutN
Apr 22, 2024
Merged
Changes from 7 commits
Commits
Show all changes
26 commits
Select commit
Hold shift + click to select a range
ef939bb
#1646 Panel accordions are not using the carbon standards
srikant-ch5 5a19d94
#1646 Panel accordions - Resolve code-test and tearsheet testcases by…
srikant-ch5 8ef25bc
Conditionally render panel accordions
srikant-ch5 f8467ee
Fix Nested Accordion Issue and classnames
srikant-ch5 89eb79c
Merge remote-tracking branch 'upstream/main' into 14295_Accordion_Rig…
srikant-ch5 f3e7f9c
##1646 Use default classnames
srikant-ch5 57ae673
Merge branch 'main' into 14295_Accordion_RightFlyoutN
matthoward366 ce5b0a0
Enable Opening of Multiple Tabs, Open Default Tab and Open Tab with A…
srikant-ch5 cf70ce6
Remove bx classname from content and describe accordion inside accordion
srikant-ch5 1846351
Merge branch 'main' into 14295_Accordion_RightFlyoutN
srikant-ch5 0533b69
Merge branch 'main' into 14295_Accordion_RightFlyoutN
matthoward366 7e01dc8
Merge branch 'main' into 14295_Accordion_RightFlyoutN
srikant-ch5 73119e9
Fix setTopLevelActiveGroup test case failure due to accordion
srikant-ch5 3237bad
Include Carbon 11 Changes in Panel Accordions
srikant-ch5 b0f62e6
Merge branch 'main' into 14295_Accordion_RightFlyoutN
srikant-ch5 c0fb47f
Fix Build issues in editor-form files
srikant-ch5 f72d07f
Revert Copyright changes in editor-form.scss
srikant-ch5 93e1b6c
Merge branch 'main' into 14295_Accordion_RightFlyoutN
srikant-ch5 4394438
Delete package-lock.json
srikant-ch5 5a31522
Merge branch 'main' into 14295_Accordion_RightFlyoutN
srikant-ch5 9455f20
Adjust Accordion height and border as per previous setup
srikant-ch5 789f4bb
Update Accordion border
srikant-ch5 1b7280b
Fix css issues by replacing classnames
srikant-ch5 283ad0e
Merge branch 'main' into 14295_Accordion_RightFlyoutN
srikant-ch5 2930b5b
Add cds--accordion__item class in editor-form css to make twisty pane…
srikant-ch5 a5131a8
Merge branch 'main' into 14295_Accordion_RightFlyoutN
srikant-ch5 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why are we using
bx--accordion__item-${i}
for a classname? This seems odd.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have removed this classname now for the content.