-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue #158 insertstyle node modules export docs #164
Issue #158 insertstyle node modules export docs #164
Conversation
- Simplified the usage notice and added link to 'package.json.files' docs.
- Simplified the usage notice and added link to 'package.json.files' docs.
I opened #163 10 minutes ago. It could solve the problem in a more "graceful" way 😄 |
:-D, yeah I saw - I figured since I had updated the snippet I would added it for correctness/have it in the git history. Started reviewing your PR though if we could get the required update on it's (apart from the prettier stuff) that would be better (as I don't get too much time for reviewing the PRs); Let's try to go for PRs/branches that build off each other (if necessary) - will allow for PR reviews to be completed faster. |
Prettier PR changes are nearly all related to code formatting, so they should't take long.
IMHO having a formatter and a linter (coming 🔜) ensure that the code is more readable and subject to errors,
If you wish you can add me as collaborator with the triage permission: I can't edit or write any information related to the repository code and settings. But with that permission at least I can at have CI checks running and avoid one review cycle just to fix some CI error 😅. If you do not want to add me, no problem, I understand 😉. |
As to your previous comment, and adding you as 'triage' user, will look into it over the next coming days. |
Hi @elycruz, thanks for the invitation 🎉. If you don't have time to review the PR's, Let me know what is the most feasible solution for you! Just a quick summary on the current 3 opened PR's if you have time to take a look:
|
@marcalexiei hey, I'm merging this one for now - you can still make the edit you require in your |
#158-__insertstyle_node_modules_export_docs
@elycruz beware that CI is failing due to format issues |
|
- Updated `insert` feature docs to reflect latest change of where rollup now outputs the 'insertStyle' module into a non-conflicting directory on build (e.g., 'dist/_virtual', etc).
Cleans up docs related to using the
insert
feature.Related to #157 and #158 .