Skip to content

try-catch for FindManyAsync #81

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sfmskywalker merged 1 commit into from
Sep 13, 2025
Merged

try-catch for FindManyAsync #81

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion src/modules/retention/Elsa.Retention/Jobs/CleanupJob.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,16 @@ public async Task ExecuteAsync(CancellationToken cancellationToken = default)

while (true)
{
var page = await workflowInstanceStore.FindManyAsync(filter, pageArgs, cancellationToken);
Page<WorkflowInstance> page;
try
{
page = await workflowInstanceStore.FindManyAsync(filter, pageArgs, cancellationToken);
}
catch (Exception ex)
{
_logger.LogError(ex, "Exception in FindManyAsync during CleanupJob. Policy: {Policy}. Cleanup aborted for this policy.", policy.Name);
break;
}

if (page.Items.Count == 0)
{
Expand Down
Loading