Fixing build for task activity attribute#77
Merged
sfmskywalker merged 2 commits intodevelop/3.6.0from Aug 7, 2025
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR updates package versions to their latest preview releases and improves code clarity in OpenTelemetry middleware by replacing an equality check with a pattern matching expression for better null safety.
- Updated Elsa and Microsoft package versions to latest preview releases
- Replaced
== truecomparison withis truepattern matching for clearer intent and null safety
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| Directory.Build.props | Updated ElsaVersion, ElsaStudioVersion, and MicrosoftVersion to latest preview releases |
| OpenTelemetryTracingActivityExecutionMiddleware.cs | Improved boolean comparison using pattern matching for better null safety |
sfmskywalker
approved these changes
Aug 7, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request primarily updates package versions and makes a minor code improvement for clarity. The most important changes are:
Dependency Updates:
ElsaVersionto3.6.0-preview.3267,ElsaStudioVersionto3.6.0-preview.1170, andMicrosoftVersionto9.0.8inDirectory.Build.propsto keep dependencies current.Code Quality Improvement:
OpenTelemetryTracingActivityExecutionMiddleware.cs, replacedactivity.GetRunAsynchronously() == truewithactivity.GetRunAsynchronously() is truefor clearer intent and improved null safety.