Skip to content

Implementing KernelFactory interface in order to allow custom factories + Using SK function that supports external tools#64

Merged
sfmskywalker merged 6 commits intoelsa-workflows:mainfrom
pugafran:IKernelFactory
Jul 3, 2025
Merged

Implementing KernelFactory interface in order to allow custom factories + Using SK function that supports external tools#64
sfmskywalker merged 6 commits intoelsa-workflows:mainfrom
pugafran:IKernelFactory

Conversation

@pugafran
Copy link

@pugafran pugafran commented Jul 3, 2025

It should be possible to modify the kernel factory through the interface in order to access the Kernel or change the public implementations.

To give an example, in my case I'm currently trying to implement MCP servers in Elsa. This will take time and requires modifying many parts of the agents folder. It’s very likely that I’ll submit a PR so Elsa can support it natively, but I should be able to use my implementation through yours NuGets without needing to implement it directly in the repository.

Right now, I'm unable to implement my code properly without access to the kernel instantiated by the KernelFactory.

Furthermore, the current function used to send the request to the AI is creating a Semantic Kernel tool that renders the prompt, and then sends the result of this toot, that is, the already rendered prompt, to the AI as a query.

This method prevents loading your own external tools, such as tools from an external MCP server.

I used a Semantic Kernel NuGet package to access the engine that renders the prompt, and I render it separately just like the original function does. Then I call ChatCompletion, which is the standard method to interact with the AI and allows the use of external tools.

It also lets you manage a ChatHistory to retain the conversation context if desired. This way, it is indeed possible to use external tools in Elsa.

There is a more advanced SK method specialized for agents, but for now, I think this is the most viable option. Currently, without this approach, external tools cannot be used.

It’s worth noting that in Elsa Studio, the format of the prompt structure and its variables is practically the same, except you no longer need to use the $, so if you have a variable named variable1, you would write {{variable1}}.

It’s literally using the same engine that renders this in the original function, the difference is that it has been customized and uses the $ for invoking internal Semantic functions, which is now deprecated. Normally, you should use an MCP.

@pugafran
Copy link
Author

pugafran commented Jul 3, 2025

@pugafran please read the following Contributor License Agreement(CLA). If you agree with the CLA, please reply with the following information.

@dotnet-policy-service agree [company="{your company}"]

Options:

  • (default - no company specified) I have sole ownership of intellectual property rights to my Submissions and I am not making Submissions in the course of work for my employer.
@dotnet-policy-service agree
  • (when company given) I am making Submissions in the course of work for my employer (or my employer has intellectual property rights in my Submissions by contract or applicable law). I have permission from my employer to make Submissions and enter into this Agreement on behalf of my employer. By signing below, the defined term “You” includes me and my employer.
@dotnet-policy-service agree company="Microsoft"

Contributor License Agreement

Contribution License Agreement

This Contribution License Agreement ( “Agreement” ) is agreed to by the party signing below ( “You” ), and conveys certain license rights to the .NET Foundation ( “.NET Foundation” ) for Your contributions to .NET Foundation open source projects. This Agreement is effective as of the latest signature date below.

1. Definitions.

“Code” means the computer software code, whether in human-readable or machine-executable form, that is delivered by You to .NET Foundation under this Agreement.

“Project” means any of the projects owned or managed by .NET Foundation and offered under a license approved by the Open Source Initiative (www.opensource.org).

“Submit” is the act of uploading, submitting, transmitting, or distributing code or other content to any Project, including but not limited to communication on electronic mailing lists, source code control systems, and issue tracking systems that are managed by, or on behalf of, the Project for the purpose of discussing and improving that Project, but excluding communication that is conspicuously marked or otherwise designated in writing by You as “Not a Submission.”

“Submission” means the Code and any other copyrightable material Submitted by You, including any associated comments and documentation.

2. Your Submission. You must agree to the terms of this Agreement before making a Submission to any Project. This Agreement covers any and all Submissions that You, now or in the future (except as described in Section 4 below), Submit to any Project.

3. Originality of Work. You represent that each of Your Submissions is entirely Your original work. Should You wish to Submit materials that are not Your original work, You may Submit them separately to the Project if You (a) retain all copyright and license information that was in the materials as you received them, (b) in the description accompanying your Submission, include the phrase "Submission containing materials of a third party:" followed by the names of the third party and any licenses or other restrictions of which You are aware, and (c) follow any other instructions in the Project's written guidelines concerning Submissions.

4. Your Employer. References to “employer” in this Agreement include Your employer or anyone else for whom You are acting in making Your Submission, e.g. as a contractor, vendor, or agent. If Your Submission is made in the course of Your work for an employer or Your employer has intellectual property rights in Your Submission by contract or applicable law, You must secure permission from Your employer to make the Submission before signing this Agreement. In that case, the term “You” in this Agreement will refer to You and the employer collectively. If You change employers in the future and desire to Submit additional Submissions for the new employer, then You agree to sign a new Agreement and secure permission from the new employer before Submitting those Submissions.

5. Licenses.

a. Copyright License. You grant .NET Foundation, and those who receive the Submission directly or indirectly from .NET Foundation, a perpetual, worldwide, non-exclusive, royalty-free, irrevocable license in the Submission to reproduce, prepare derivative works of, publicly display, publicly perform, and distribute the Submission and such derivative works, and to sublicense any or all of the foregoing rights to third parties.

b. Patent License. You grant .NET Foundation, and those who receive the Submission directly or indirectly from .NET Foundation, a perpetual, worldwide, non-exclusive, royalty-free, irrevocable license under Your patent claims that are necessarily infringed by the Submission or the combination of the Submission with the Project to which it was Submitted to make, have made, use, offer to sell, sell and import or otherwise dispose of the Submission alone or with the Project.

c. Other Rights Reserved. Each party reserves all rights not expressly granted in this Agreement. No additional licenses or rights whatsoever (including, without limitation, any implied licenses) are granted by implication, exhaustion, estoppel or otherwise.

6. Representations and Warranties. You represent that You are legally entitled to grant the above licenses. You represent that each of Your Submissions is entirely Your original work (except as You may have disclosed under Section 3 ). You represent that You have secured permission from Your employer to make the Submission in cases where Your Submission is made in the course of Your work for Your employer or Your employer has intellectual property rights in Your Submission by contract or applicable law. If You are signing this Agreement on behalf of Your employer, You represent and warrant that You have the necessary authority to bind the listed employer to the obligations contained in this Agreement. You are not expected to provide support for Your Submission, unless You choose to do so. UNLESS REQUIRED BY APPLICABLE LAW OR AGREED TO IN WRITING, AND EXCEPT FOR THE WARRANTIES EXPRESSLY STATED IN SECTIONS 3, 4, AND 6 , THE SUBMISSION PROVIDED UNDER THIS AGREEMENT IS PROVIDED WITHOUT WARRANTY OF ANY KIND, INCLUDING, BUT NOT LIMITED TO, ANY WARRANTY OF NONINFRINGEMENT, MERCHANTABILITY, OR FITNESS FOR A PARTICULAR PURPOSE.

7. Notice to .NET Foundation. You agree to notify .NET Foundation in writing of any facts or circumstances of which You later become aware that would make Your representations in this Agreement inaccurate in any respect.

8. Information about Submissions. You agree that contributions to Projects and information about contributions may be maintained indefinitely and disclosed publicly, including Your name and other information that You submit with Your Submission.

9. Governing Law/Jurisdiction. This Agreement is governed by the laws of the State of Washington, and the parties consent to exclusive jurisdiction and venue in the federal courts sitting in King County, Washington, unless no federal subject matter jurisdiction exists, in which case the parties consent to exclusive jurisdiction and venue in the Superior Court of King County, Washington. The parties waive all defenses of lack of personal jurisdiction and forum non-conveniens.

10. Entire Agreement/Assignment. This Agreement is the entire agreement between the parties, and supersedes any and all prior agreements, understandings or communications, written or oral, between the parties relating to the subject matter hereof. This Agreement may be assigned by .NET Foundation.

.NET Foundation dedicates this Contribution License Agreement to the public domain according to the Creative Commons CC0 1.

@dotnet-policy-service agree

@pugafran pugafran marked this pull request as ready for review July 3, 2025 14:15
Copy link
Member

@sfmskywalker sfmskywalker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like your PR in general, I only have a few small requests and some questions, which server more to increase my understanding than anything else. Thank you :)

Comment on lines +21 to +28
try
{
return JsonSerializer.Deserialize<JsonElement>(content!);
}
catch (JsonException ex)
{
throw new InvalidOperationException($"Error deserializing the message content as JSON:\n{content}", ex);
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Out of curiosity, why is it better to explicitly handle a serialization exception and then wrapping it in an IOE?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added the explicit handling of JsonException and wrapped it in an InvalidOperationException mainly as a defensive programming measure.

Over the past few weeks, I’ve been doing a kind of reverse engineering to fully understand how the repository and the NuGet packages interact. I wanted to make sure I could trust and trace what's going on at every level while I was testing.

So this change was mostly precautionary, happy to revert or adjust it!

You probably have everything more aligned in your mind and clearly understand which parts interact and why. Since this is still 'new' to me, it's harder for me to reach those conclusions so quickly, haha. That's why I added that detail, more like a 'let me specify this for a moment, so if it breaks, I'll know what caused it.'

Copy link
Member

@sfmskywalker sfmskywalker Jul 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Got it, makes sense 👍🏻 Perhaps it'a not a bad practice actually, especially if we throw a custom exception to make it extra clear what's happening. In this case, it's failing to parse the agent's response as JSON, so that would be a nice message to include with a custom exception class called e.g. FunctionCallException or AgentInvocationException. If you agree, please add an exception class with a name that you think makes sense in this context. Alternatively, I'm happy to do so myself once this is merged.

@pugafran
Copy link
Author

pugafran commented Jul 3, 2025

I like your PR in general, I only have a few small requests and some questions, which server more to increase my understanding than anything else. Thank you :)

I have to leave right now, but I’ll try to answer your questions and correct the mistakes as soon as I can during the day.

Thank you very much for your quick response and effort!

@pugafran
Copy link
Author

pugafran commented Jul 3, 2025

I believe I’ve addressed all the comments, there are a couple I haven’t marked as “resolved” since I think they depend on your opinion haha.

With these changes, for example, I’d already be able to implement MCPs in my custom KernelFactory, and they’d work because this method in AgentInvoker supports tools.

Also, as a remember, by using chat-style methods, you can choose whether to store the history/context, which gives you more flexibility.

Btw, as I mentioned before, there’s a ChatCompletionAgent that allows patterns like orchestration, handoff, among others. For now, though, this PR serves as a solid base implementation, I wouldn’t dive into implementing the new Agents features from Semantic Kernel without having this foundation in place first.

I highly recommend checking out this microsoft course (I did hah) for the future too, it’s super relevant if we’re planning to implement full native Agent support using Semantic Kernel. They explain it in Python, but everything is already available in C# as well.

Let me know if you need anything, I’m around! And sorry, I still owe you that email from a few weeks ago. But anyway, this was pretty much what I wanted to discuss: agents and Semantic Kernel.

@sfmskywalker
Copy link
Member

Great! Thank you for your detailed rundown, it helps me a lot that you know more about Semantic Kernel than I do. I appreciate the linked Microsoft course and will definitely check it!

I noticed their Agent framework many months ago when it was still in preview (maybe it still is), and I couldn't quite figure out yet how it might or might not fit with my agent definition setup. However, I definitely think we want to implement fill native Agent support using SK, and the fact that you think with this PR we have a solid base increases my confidence level that we're on the right path with the way we're using SK.

Thanks for your support!

@sfmskywalker sfmskywalker merged commit eef3791 into elsa-workflows:main Jul 3, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants