Slack Integration#30
Merged
sfmskywalker merged 4 commits intoelsa-workflows:mainfrom Feb 23, 2025
adamfisher:feature/integration-slack
Merged
Slack Integration#30sfmskywalker merged 4 commits intoelsa-workflows:mainfrom adamfisher:feature/integration-slack
sfmskywalker merged 4 commits intoelsa-workflows:mainfrom
adamfisher:feature/integration-slack
Conversation
This commit introduces the Azure Storage integration for the Elsa framework. It includes features for managing `BlobServiceClient` and `BlobContainerClient` instances, as well as utilities for efficient JSON streaming and parallel block blob uploads to Azure Blob Storage. Configuration is provided via `.editorconfig`, project settings, and centralized NuGet dependencies.
…d to just my changes
sfmskywalker
approved these changes
Feb 23, 2025
Member
sfmskywalker
left a comment
There was a problem hiding this comment.
I think this is a great starting point. Regarding your comment on automated tests, I agree that we should start with unit tests and leave the end-to-end tests be, for now. As for XML documentation, I hear you, but we will probably be adding it anyway because it does help others to understand how things are to be used and fit together (when written properly). That said, I won't require it for this PR to go in.
Thank you for this awesome PR!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #26
A few things to note or consider:
WatchDirectMessagesacts as a trigger activity and waits for a new slack message to be published to a channel for the workflow to start).MoqorNSubstituteand usingBogus.Fakerto generate fake responses for these services and doing only unit testing will allow us to scale nicely as we add more services.