Skip to content

Fix resource leak in AppComponentTest by disposing service scope #105

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sfmskywalker merged 3 commits into from
Dec 24, 2025
Merged

Fix resource leak in AppComponentTest by disposing service scope #105

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f216d5b
Initial plan
Copilot Dec 24, 2025
23625be
Fix resource leak by disposing Scope in AppComponentTest
Copilot Dec 24, 2025
75c1549
Add null-conditional operator to Scope disposal for extra safety
Copilot Dec 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions ...modules/scheduling/Elsa.Scheduling.Quartz.ComponentTests/Abstractions/AppComponentTest.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@ public abstract class AppComponentTest(SchedulingApp app) : IDisposable
public void Dispose()
{
OnDispose();
Scope?.Dispose();
Copy link

Copilot AI Dec 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change may cause test runner hangs. There's an identical AppComponentTest class in test/modules/servicebus/Elsa.ServiceBus.AzureServiceBus.ComponentTests/Abstractions/AppComponentTest.cs that has a similar Scope property, but the disposal is commented out with an explicit warning: "Disposing the Scope here and in other places where it is created somehow seems to cause the test runner to hang when running other test projects."

Before merging this change, please verify that disposing the Scope in this test class doesn't cause similar hanging issues. Consider running the full test suite, including other test projects, to ensure this doesn't introduce instability.

Suggested change
Scope?.Dispose();
// Do not dispose Scope here. Disposing the Scope in similar component test base classes
// has been observed to cause the test runner to hang when running other test projects.

Copilot uses AI. Check for mistakes.
GC.SuppressFinalize(this);
}

Expand Down
Loading