Add overloads to UseAzureServiceBus for enhanced configuration flexibility.#100
Merged
sfmskywalker merged 4 commits intodevelop/3.6.0from Dec 19, 2025
Merged
Add overloads to UseAzureServiceBus for enhanced configuration flexibility.#100sfmskywalker merged 4 commits intodevelop/3.6.0from
UseAzureServiceBus for enhanced configuration flexibility.#100sfmskywalker merged 4 commits intodevelop/3.6.0from
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR enhances the Azure Service Bus integration by adding method overloads to UseAzureServiceBus for more flexible configuration options. However, the implementation contains critical syntax errors that prevent compilation.
Key Changes:
- Adds three overloads for
UseAzureServiceBusto support different configuration scenarios: connection string, custom clients with host address, and direct feature configuration - Introduces new imports for
Azure.Messaging.ServiceBusandMassTransitnamespaces
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
...odules/servicebus/Elsa.ServiceBus.MassTransit.AzureServiceBus/Extensions/ModuleExtensions.cs
Show resolved
Hide resolved
...odules/servicebus/Elsa.ServiceBus.MassTransit.AzureServiceBus/Extensions/ModuleExtensions.cs
Outdated
Show resolved
Hide resolved
...odules/servicebus/Elsa.ServiceBus.MassTransit.AzureServiceBus/Extensions/ModuleExtensions.cs
Show resolved
Hide resolved
...odules/servicebus/Elsa.ServiceBus.MassTransit.AzureServiceBus/Extensions/ModuleExtensions.cs
Show resolved
Hide resolved
...odules/servicebus/Elsa.ServiceBus.MassTransit.AzureServiceBus/Extensions/ModuleExtensions.cs
Show resolved
Hide resolved
…eBus/Extensions/ModuleExtensions.cs Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Ensures correct configuration of the Azure Service Bus transport bus by using the += operator instead of conditional assignment. This prevents potential issues where the configuration might be overwritten. Also, initializes the ConfigureTransportBus action to prevent null reference exceptions.
Updated `AzureServiceBusOptions` and `ServiceBusAdministrationClientFactory` to use `+=` instead of direct assignment. This ensures proper appending of handlers and avoids overwriting existing configurations.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The overload provides a convenient way to provide a manually created ASB client, offering greater control to the host application. For example, the host application can now create an ASB client using a TokenCredential, rather than being limited to passing in a connection string.