Skip to content

Fix ActivityNodeId column truncation for deeply nested workflows #7338

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sfmskywalker merged 5 commits into from
Mar 2, 2026
Merged

Fix ActivityNodeId column truncation for deeply nested workflows #7338

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
d1da8b1
Initial plan
Copilot Mar 2, 2026
7af6dc8
Increase ActivityNodeId column max length from 450 to 1024 to fix tru…
Copilot Mar 2, 2026
6c73d5d
Use NVARCHAR(MAX) and equivalent unlimited column types for ActivityN…
Copilot Mar 2, 2026
18980a6
Add IF EXISTS guards to DropIndex calls in V3_6 migrations for all pr…
Copilot Mar 2, 2026
452ffdb
Add comment explaining Oracle error code -1418 in migration
Copilot Mar 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 2 additions & 8 deletions src/modules/Elsa.Persistence.EFCore.MySql/Migrations/Runtime/20251204150235_V3_6.Designer.cs
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

66 changes: 66 additions & 0 deletions src/modules/Elsa.Persistence.EFCore.MySql/Migrations/Runtime/20251204150235_V3_6.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,38 @@ protected override void Up(MigrationBuilder migrationBuilder)
table: "Triggers",
columns: new[] { "WorkflowDefinitionId", "Hash", "ActivityId", "TenantId" },
unique: true);

migrationBuilder.DropIndex(
name: "IX_WorkflowExecutionLogRecord_ActivityNodeId",
schema: _schema.Schema,
table: "WorkflowExecutionLogRecords");

migrationBuilder.DropIndex(
name: "IX_ActivityExecutionRecord_ActivityNodeId",
schema: _schema.Schema,
table: "ActivityExecutionRecords");

migrationBuilder.AlterColumn<string>(
name: "ActivityNodeId",
schema: _schema.Schema,
table: "WorkflowExecutionLogRecords",
type: "longtext",
nullable: false,
oldClrType: typeof(string),
oldType: "varchar(255)")
.Annotation("MySql:CharSet", "utf8mb4")
.OldAnnotation("MySql:CharSet", "utf8mb4");

migrationBuilder.AlterColumn<string>(
name: "ActivityNodeId",
schema: _schema.Schema,
table: "ActivityExecutionRecords",
type: "longtext",
nullable: false,
oldClrType: typeof(string),
oldType: "varchar(255)")
.Annotation("MySql:CharSet", "utf8mb4")
.OldAnnotation("MySql:CharSet", "utf8mb4");
}

/// <inheritdoc />
Expand All @@ -55,6 +87,40 @@ protected override void Down(MigrationBuilder migrationBuilder)
oldType: "varchar(255)")
.Annotation("MySql:CharSet", "utf8mb4")
.OldAnnotation("MySql:CharSet", "utf8mb4");

migrationBuilder.AlterColumn<string>(
name: "ActivityNodeId",
schema: _schema.Schema,
table: "WorkflowExecutionLogRecords",
type: "varchar(255)",
nullable: false,
oldClrType: typeof(string),
oldType: "longtext")
.Annotation("MySql:CharSet", "utf8mb4")
.OldAnnotation("MySql:CharSet", "utf8mb4");

migrationBuilder.AlterColumn<string>(
name: "ActivityNodeId",
schema: _schema.Schema,
table: "ActivityExecutionRecords",
type: "varchar(255)",
nullable: false,
oldClrType: typeof(string),
oldType: "longtext")
.Annotation("MySql:CharSet", "utf8mb4")
.OldAnnotation("MySql:CharSet", "utf8mb4");

migrationBuilder.CreateIndex(
name: "IX_WorkflowExecutionLogRecord_ActivityNodeId",
schema: _schema.Schema,
table: "WorkflowExecutionLogRecords",
column: "ActivityNodeId");

migrationBuilder.CreateIndex(
name: "IX_ActivityExecutionRecord_ActivityNodeId",
schema: _schema.Schema,
table: "ActivityExecutionRecords",
column: "ActivityNodeId");
Comment on lines +103 to +135

@greptile-apps greptile-apps Bot Mar 2, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Down migration will silently truncate or fail on existing long-value rows

The MySQL Down() migration narrows ActivityNodeId back from longtext to varchar(255). Any row that was inserted with a value longer than 255 characters (the exact scenario this PR was created to fix) will either be silently truncated (when sql_mode does not include STRICT_TRANS_TABLES) or cause the rollback to fail entirely (when strict mode is on).

The same risk applies to the Oracle Down() migration (NCLOB → NVARCHAR2(450)) and the SQL Server Down() migration (nvarchar(max) → nvarchar(450)).

Because data loss on rollback is irreversible, the Down() migration should at minimum document this limitation with a comment, or guard the column change with an explicit truncation/assertion step that makes the data-loss risk visible rather than silent.

@sfmskywalker sfmskywalker Mar 2, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@copilot Please look into this comment.

}
}
}
10 changes: 2 additions & 8 deletions ...les/Elsa.Persistence.EFCore.MySql/Migrations/Runtime/RuntimeElsaDbContextModelSnapshot.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,7 @@ protected override void BuildModel(ModelBuilder modelBuilder)

b.Property<string>("ActivityNodeId")
.IsRequired()
.HasColumnType("varchar(255)");
.HasColumnType("longtext");

b.Property<string>("ActivityType")
.IsRequired()
Expand Down Expand Up @@ -117,9 +117,6 @@ protected override void BuildModel(ModelBuilder modelBuilder)
b.HasIndex("ActivityName")
.HasDatabaseName("IX_ActivityExecutionRecord_ActivityName");

b.HasIndex("ActivityNodeId")
.HasDatabaseName("IX_ActivityExecutionRecord_ActivityNodeId");

b.HasIndex("ActivityType")
.HasDatabaseName("IX_ActivityExecutionRecord_ActivityType");

Expand Down Expand Up @@ -339,7 +336,7 @@ protected override void BuildModel(ModelBuilder modelBuilder)

b.Property<string>("ActivityNodeId")
.IsRequired()
.HasColumnType("varchar(255)");
.HasColumnType("longtext");

b.Property<string>("ActivityType")
.IsRequired()
Expand Down Expand Up @@ -401,9 +398,6 @@ protected override void BuildModel(ModelBuilder modelBuilder)
b.HasIndex("ActivityName")
.HasDatabaseName("IX_WorkflowExecutionLogRecord_ActivityName");

b.HasIndex("ActivityNodeId")
.HasDatabaseName("IX_WorkflowExecutionLogRecord_ActivityNodeId");

b.HasIndex("ActivityType")
.HasDatabaseName("IX_WorkflowExecutionLogRecord_ActivityType");

Expand Down
10 changes: 2 additions & 8 deletions ...modules/Elsa.Persistence.EFCore.Oracle/Migrations/Runtime/20251204150355_V3_6.Designer.cs
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

58 changes: 58 additions & 0 deletions src/modules/Elsa.Persistence.EFCore.Oracle/Migrations/Runtime/20251204150355_V3_6.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,34 @@ protected override void Up(MigrationBuilder migrationBuilder)
columns: new[] { "WorkflowDefinitionId", "Hash", "ActivityId", "TenantId" },
unique: true,
filter: "\"Hash\" IS NOT NULL");

migrationBuilder.DropIndex(
name: "IX_WorkflowExecutionLogRecord_ActivityNodeId",
schema: _schema.Schema,
table: "WorkflowExecutionLogRecords");

migrationBuilder.DropIndex(
name: "IX_ActivityExecutionRecord_ActivityNodeId",
schema: _schema.Schema,
table: "ActivityExecutionRecords");

migrationBuilder.AlterColumn<string>(
name: "ActivityNodeId",
schema: _schema.Schema,
table: "WorkflowExecutionLogRecords",
type: "NCLOB",
nullable: false,
oldClrType: typeof(string),
oldType: "NVARCHAR2(450)");

migrationBuilder.AlterColumn<string>(
name: "ActivityNodeId",
schema: _schema.Schema,
table: "ActivityExecutionRecords",
type: "NCLOB",
nullable: false,
oldClrType: typeof(string),
oldType: "NVARCHAR2(450)");
}

/// <inheritdoc />
Expand All @@ -34,6 +62,36 @@ protected override void Down(MigrationBuilder migrationBuilder)
name: "IX_StoredTrigger_Unique_WorkflowDefinitionId_Hash_ActivityId_TenantId",
schema: _schema.Schema,
table: "Triggers");

migrationBuilder.AlterColumn<string>(
name: "ActivityNodeId",
schema: _schema.Schema,
table: "WorkflowExecutionLogRecords",
type: "NVARCHAR2(450)",
nullable: false,
oldClrType: typeof(string),
oldType: "NCLOB");

migrationBuilder.AlterColumn<string>(
name: "ActivityNodeId",
schema: _schema.Schema,
table: "ActivityExecutionRecords",
type: "NVARCHAR2(450)",
nullable: false,
oldClrType: typeof(string),
oldType: "NCLOB");

migrationBuilder.CreateIndex(
name: "IX_WorkflowExecutionLogRecord_ActivityNodeId",
schema: _schema.Schema,
table: "WorkflowExecutionLogRecords",
column: "ActivityNodeId");

migrationBuilder.CreateIndex(
name: "IX_ActivityExecutionRecord_ActivityNodeId",
schema: _schema.Schema,
table: "ActivityExecutionRecords",
column: "ActivityNodeId");
}
}
}
10 changes: 2 additions & 8 deletions ...es/Elsa.Persistence.EFCore.Oracle/Migrations/Runtime/RuntimeElsaDbContextModelSnapshot.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,7 @@ protected override void BuildModel(ModelBuilder modelBuilder)

b.Property<string>("ActivityNodeId")
.IsRequired()
.HasColumnType("NVARCHAR2(450)");
.HasColumnType("NCLOB");

b.Property<string>("ActivityType")
.IsRequired()
Expand Down Expand Up @@ -117,9 +117,6 @@ protected override void BuildModel(ModelBuilder modelBuilder)
b.HasIndex("ActivityName")
.HasDatabaseName("IX_ActivityExecutionRecord_ActivityName");

b.HasIndex("ActivityNodeId")
.HasDatabaseName("IX_ActivityExecutionRecord_ActivityNodeId");

b.HasIndex("ActivityType")
.HasDatabaseName("IX_ActivityExecutionRecord_ActivityType");

Expand Down Expand Up @@ -340,7 +337,7 @@ protected override void BuildModel(ModelBuilder modelBuilder)

b.Property<string>("ActivityNodeId")
.IsRequired()
.HasColumnType("NVARCHAR2(450)");
.HasColumnType("NCLOB");

b.Property<string>("ActivityType")
.IsRequired()
Expand Down Expand Up @@ -402,9 +399,6 @@ protected override void BuildModel(ModelBuilder modelBuilder)
b.HasIndex("ActivityName")
.HasDatabaseName("IX_WorkflowExecutionLogRecord_ActivityName");

b.HasIndex("ActivityNodeId")
.HasDatabaseName("IX_WorkflowExecutionLogRecord_ActivityNodeId");

b.HasIndex("ActivityType")
.HasDatabaseName("IX_WorkflowExecutionLogRecord_ActivityType");

Expand Down
6 changes: 0 additions & 6 deletions ...les/Elsa.Persistence.EFCore.PostgreSql/Migrations/Runtime/20251204150341_V3_6.Designer.cs
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

22 changes: 22 additions & 0 deletions src/modules/Elsa.Persistence.EFCore.PostgreSql/Migrations/Runtime/20251204150341_V3_6.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,16 @@ protected override void Up(MigrationBuilder migrationBuilder)
table: "Triggers",
columns: new[] { "WorkflowDefinitionId", "Hash", "ActivityId", "TenantId" },
unique: true);

migrationBuilder.DropIndex(
name: "IX_WorkflowExecutionLogRecord_ActivityNodeId",
schema: _schema.Schema,
table: "WorkflowExecutionLogRecords");

migrationBuilder.DropIndex(
name: "IX_ActivityExecutionRecord_ActivityNodeId",
schema: _schema.Schema,
table: "ActivityExecutionRecords");
}

/// <inheritdoc />
Expand All @@ -33,6 +43,18 @@ protected override void Down(MigrationBuilder migrationBuilder)
name: "IX_StoredTrigger_Unique_WorkflowDefinitionId_Hash_ActivityId_TenantId",
schema: _schema.Schema,
table: "Triggers");

migrationBuilder.CreateIndex(
name: "IX_WorkflowExecutionLogRecord_ActivityNodeId",
schema: _schema.Schema,
table: "WorkflowExecutionLogRecords",
column: "ActivityNodeId");

migrationBuilder.CreateIndex(
name: "IX_ActivityExecutionRecord_ActivityNodeId",
schema: _schema.Schema,
table: "ActivityExecutionRecords",
column: "ActivityNodeId");
}
}
}
6 changes: 0 additions & 6 deletions ...lsa.Persistence.EFCore.PostgreSql/Migrations/Runtime/RuntimeElsaDbContextModelSnapshot.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -117,9 +117,6 @@ protected override void BuildModel(ModelBuilder modelBuilder)
b.HasIndex("ActivityName")
.HasDatabaseName("IX_ActivityExecutionRecord_ActivityName");

b.HasIndex("ActivityNodeId")
.HasDatabaseName("IX_ActivityExecutionRecord_ActivityNodeId");

b.HasIndex("ActivityType")
.HasDatabaseName("IX_ActivityExecutionRecord_ActivityType");

Expand Down Expand Up @@ -401,9 +398,6 @@ protected override void BuildModel(ModelBuilder modelBuilder)
b.HasIndex("ActivityName")
.HasDatabaseName("IX_WorkflowExecutionLogRecord_ActivityName");

b.HasIndex("ActivityNodeId")
.HasDatabaseName("IX_WorkflowExecutionLogRecord_ActivityNodeId");

b.HasIndex("ActivityType")
.HasDatabaseName("IX_WorkflowExecutionLogRecord_ActivityType");

Expand Down
Loading