Skip to content

Preserve metadata for unknown activities #7323

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sfmskywalker merged 4 commits into from
Feb 25, 2026
Merged

Preserve metadata for unknown activities #7323

Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
ff991b8
Extract and copy metadata when activity type is not found in `Activit…
sfmskywalker Feb 25, 2026
4f37a81
Improve `ActivityJsonConverter`: Correct metadata extraction to read …
sfmskywalker Feb 25, 2026
daa0f57
Reposition activity description and display text assignment to follow…
sfmskywalker Feb 25, 2026
2b4cd4f
Update src/modules/Elsa.Workflows.Core/Serialization/Converters/Activ…
sfmskywalker Feb 25, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 15 additions & 0 deletions src/modules/Elsa.Workflows.Core/Serialization/Converters/ActivityJsonConverter.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,8 +52,23 @@ public override IActivity Read(ref Utf8JsonReader reader, Type typeToConvert, Js
notFoundActivity.MissingTypeName = activityTypeName;
notFoundActivity.MissingTypeVersion = activityTypeVersion;
notFoundActivity.OriginalActivityJson = activityRoot.ToString();

// Extract and copy metadata from the outer NotFoundActivity JSON wrapper (doc.RootElement).
// Note: activityRoot may contain the inner originalActivityJson, so we must read from doc.RootElement
// to get the metadata that was added to the NotFoundActivity wrapper itself.
Comment thread
sfmskywalker marked this conversation as resolved.
Outdated
if (doc.RootElement.TryGetProperty("metadata", out var outerMetadataElement))
{
var outerMetadata = JsonSerializer.Deserialize<IDictionary<string, object>>(outerMetadataElement.GetRawText(), clonedOptions);
if (outerMetadata != null)
{
notFoundActivity.Metadata = outerMetadata;
}
}

// Set display text and description after metadata assignment to ensure they always reflect the current state
notFoundActivity.SetDisplayText($"Not Found: {activityTypeName}");
notFoundActivity.SetDescription($"Could not find activity type {activityTypeName} with version {activityTypeVersion}");

return notFoundActivity;
}

Expand Down