Deterministic ZIP export and 404 test coverage for consumers endpoint

[Copilot]

Two unresolved review comments addressed: ZIP export was non-deterministic across identical inputs, and the consumers endpoint lacked test coverage for the 404 path.

Changes

• Deterministic ZIP output (Export/Endpoint.cs)

  • Sort definitions by DefinitionId before writing entries — eliminates ordering variance from DB query results
  • Set entry.LastWriteTime = DateTimeOffset.UnixEpoch on every ZipArchiveEntry — eliminates timestamp variance in ZIP headers

• 404 test coverage (WorkflowReferenceGraphTests.cs)

  • Added ConsumersEndpoint_UnknownWorkflow_ReturnsNotFound: calls GetConsumersAsync with a non-existent definition ID and asserts Refit.ApiException with HttpStatusCode.NotFound

---

✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.

[greptile-apps]

Greptile Summary

This PR addresses two specific code review comments by ensuring deterministic ZIP exports and adding test coverage for the 404 error path in the consumers endpoint.

• Deterministic ZIP export: Sorts workflow definitions by DefinitionId before creating archive entries and sets LastWriteTime to DateTimeOffset.UnixEpoch to eliminate ordering and timestamp variance
• 404 test coverage: Added ConsumersEndpoint_UnknownWorkflow_ReturnsNotFound test that verifies the consumers endpoint correctly returns 404 for non-existent workflow definitions

The changes are minimal, focused, and directly address the stated review comments without introducing side effects.

Confidence Score: 5/5

• This PR is safe to merge with minimal risk
• The changes are well-scoped bug fixes that improve determinism and test coverage. The ZIP export sorting and timestamp normalization are straightforward additions that don't affect business logic. The new test follows existing patterns and properly validates 404 behavior.
• No files require special attention

Important Files Changed

Filename	Overview
src/modules/Elsa.Workflows.Api/Endpoints/WorkflowDefinitions/Export/Endpoint.cs	Adds deterministic ZIP export by sorting definitions by DefinitionId and setting LastWriteTime to Unix epoch
test/component/Elsa.Workflows.ComponentTests/Scenarios/WorkflowReferenceGraph/WorkflowReferenceGraphTests.cs	Adds 404 test coverage for consumers endpoint with non-existent workflow definition ID

Flowchart

%%{init: {'theme': 'neutral'}}%%
flowchart TD
    A[WriteZipResponseAsync] --> B[Sort definitions by DefinitionId]
    B --> C[Create ZIP Archive]
    C --> D[For each sorted definition]
    D --> E[Create WorkflowModel]
    E --> F[Serialize to JSON]
    F --> G[Create ZIP entry with filename]
    G --> H[Set LastWriteTime to UnixEpoch]
    H --> I[Write JSON to entry stream]
    I --> J{More definitions?}
    J -->|Yes| D
    J -->|No| K[Send ZIP to client]

Loading

_{Last reviewed commit: 7314adb}