Replace DistributedLock meta-package with DistributedLock.Core in Elsa.Common#7169
Merged
sfmskywalker merged 2 commits intorelease/3.6.0from Dec 24, 2025
Merged
Conversation
…a.Common Co-authored-by: sfmskywalker <938393+sfmskywalker@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix unneeded references in project output
Replace DistributedLock meta-package with DistributedLock.Core in Elsa.Common
Dec 24, 2025
sfmskywalker
approved these changes
Dec 24, 2025
Contributor
There was a problem hiding this comment.
Pull request overview
This PR optimizes package dependencies by replacing the DistributedLock meta-package with DistributedLock.Core in the Elsa.Common module. This change eliminates unnecessary transitive dependencies from provider implementations (SQL Server, Redis, PostgreSQL, Azure, FileSystem, etc.) that are not used by this module.
Key Changes:
- Replace
DistributedLockwithDistributedLock.Corepackage reference inElsa.Common.csproj
The module only requires the core abstractions (IDistributedLock, IDistributedLockProvider, IDistributedSynchronizationHandle) from the Medallion.Threading namespace, which are all provided by DistributedLock.Core. Modules that need specific provider implementations (like Elsa.Workflows.Runtime with DistributedLock.FileSystem) already reference them directly.
This was referenced Mar 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Elsa.Commonwas referencing theDistributedLockmeta-package, which transitively pulls in all provider implementations (SQL Server, Redis, PostgreSQL, Azure, FileSystem, etc.) despite only using the core abstractions.Changes
DistributedLockpackage reference withDistributedLock.CoreinElsa.Common.csprojThe module only uses interfaces from
Medallion.Threadingnamespace (IDistributedLock,IDistributedLockProvider,IDistributedSynchronizationHandle), which are provided byDistributedLock.Core. Provider-specific implementations remain available to modules that explicitly need them (e.g.,Elsa.Workflows.RuntimewithDistributedLock.FileSystem).Original prompt
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.
This change is