Upgrade projects to target .NET 10, add conditional System.Linq.Async dependencies for compatibility with earlier frameworks, and update project files for consistency across the solution.#7062
Merged
sfmskywalker merged 3 commits intodevelop/3.6.0from Nov 21, 2025
Conversation
…c` dependencies for compatibility with earlier frameworks, and update project files for consistency across the solution.
Contributor
There was a problem hiding this comment.
Pull Request Overview
This pull request upgrades the Elsa Workflows project to target .NET 10 as the primary framework, adds conditional System.Linq.Async package references for earlier frameworks, and consolidates project configurations by removing redundant TargetFramework declarations in favor of inheritance from Directory.Build.props files.
Key Changes:
- Upgraded target frameworks from
net9.0tonet10.0across apps and test projects, and addednet10.0to multi-targeting in source modules - Introduced conditional
System.Linq.Asyncpackage references that exclude .NET 10, based on a claim of native async LINQ support - Refactored test project files to inherit
TargetFrameworkfrom parentDirectory.Build.propsfor consistency
Reviewed Changes
Copilot reviewed 11 out of 11 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
src/Directory.Build.props |
Added net10.0 to the multi-targeting frameworks list alongside net8.0 and net9.0 |
src/apps/Directory.Build.props |
Changed single target framework from net9.0 to net10.0 for application projects |
test/Directory.Build.props |
Updated test projects' target framework from net9.0 to net10.0 |
test/performance/Directory.Build.props |
Added import statement to inherit from parent Directory.Build.props and removed redundant whitespace |
test/performance/Elsa.Workflows.PerformanceTests/Elsa.Workflows.PerformanceTests.csproj |
Removed explicit TargetFramework declaration to inherit from parent Directory.Build.props |
test/integration/Elsa.Resilience.IntegrationTests/Elsa.Resilience.IntegrationTests.csproj |
Removed explicit TargetFramework declaration to inherit from parent Directory.Build.props |
test/integration/Elsa.JavaScript.IntegrationTests/Elsa.JavaScript.IntegrationTests.csproj |
Removed explicit TargetFramework declaration to inherit from parent Directory.Build.props |
test/integration/Elsa.Activities.IntegrationTests/Elsa.Activities.IntegrationTests.csproj |
Removed explicit TargetFramework declaration to inherit from parent Directory.Build.props |
test/component/Elsa.Workflows.ComponentTests/Elsa.Workflows.ComponentTests.csproj |
Removed explicit TargetFramework declaration to inherit from parent Directory.Build.props |
src/modules/Elsa.Workflows.Core/Elsa.Workflows.Core.csproj |
Added conditional System.Linq.Async package reference that excludes net10.0 with comment about native async LINQ support |
src/modules/Elsa.Expressions.JavaScript/Elsa.Expressions.JavaScript.csproj |
Added conditional System.Linq.Async package reference that excludes net10.0 with comment about native async LINQ support |
src/modules/Elsa.Expressions.JavaScript/Elsa.Expressions.JavaScript.csproj
Show resolved
Hide resolved
…ove xUnit references from performance test project.
…ate MSBuild properties for BenchmarkDotNet.
This was referenced Nov 16, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #7057
This change is