Skip to content

Upgrade projects to target .NET 10, add conditional System.Linq.Async dependencies for compatibility with earlier frameworks, and update project files for consistency across the solution.#7062

Merged
sfmskywalker merged 3 commits intodevelop/3.6.0from
chore/net10
Nov 21, 2025

Conversation

@sfmskywalker
Copy link
Member

@sfmskywalker sfmskywalker commented Nov 14, 2025

Fixes #7057

This change is Reviewable

…c` dependencies for compatibility with earlier frameworks, and update project files for consistency across the solution.
Copilot AI review requested due to automatic review settings November 14, 2025 20:55
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This pull request upgrades the Elsa Workflows project to target .NET 10 as the primary framework, adds conditional System.Linq.Async package references for earlier frameworks, and consolidates project configurations by removing redundant TargetFramework declarations in favor of inheritance from Directory.Build.props files.

Key Changes:

  • Upgraded target frameworks from net9.0 to net10.0 across apps and test projects, and added net10.0 to multi-targeting in source modules
  • Introduced conditional System.Linq.Async package references that exclude .NET 10, based on a claim of native async LINQ support
  • Refactored test project files to inherit TargetFramework from parent Directory.Build.props for consistency

Reviewed Changes

Copilot reviewed 11 out of 11 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
src/Directory.Build.props Added net10.0 to the multi-targeting frameworks list alongside net8.0 and net9.0
src/apps/Directory.Build.props Changed single target framework from net9.0 to net10.0 for application projects
test/Directory.Build.props Updated test projects' target framework from net9.0 to net10.0
test/performance/Directory.Build.props Added import statement to inherit from parent Directory.Build.props and removed redundant whitespace
test/performance/Elsa.Workflows.PerformanceTests/Elsa.Workflows.PerformanceTests.csproj Removed explicit TargetFramework declaration to inherit from parent Directory.Build.props
test/integration/Elsa.Resilience.IntegrationTests/Elsa.Resilience.IntegrationTests.csproj Removed explicit TargetFramework declaration to inherit from parent Directory.Build.props
test/integration/Elsa.JavaScript.IntegrationTests/Elsa.JavaScript.IntegrationTests.csproj Removed explicit TargetFramework declaration to inherit from parent Directory.Build.props
test/integration/Elsa.Activities.IntegrationTests/Elsa.Activities.IntegrationTests.csproj Removed explicit TargetFramework declaration to inherit from parent Directory.Build.props
test/component/Elsa.Workflows.ComponentTests/Elsa.Workflows.ComponentTests.csproj Removed explicit TargetFramework declaration to inherit from parent Directory.Build.props
src/modules/Elsa.Workflows.Core/Elsa.Workflows.Core.csproj Added conditional System.Linq.Async package reference that excludes net10.0 with comment about native async LINQ support
src/modules/Elsa.Expressions.JavaScript/Elsa.Expressions.JavaScript.csproj Added conditional System.Linq.Async package reference that excludes net10.0 with comment about native async LINQ support

…ove xUnit references from performance test project.
Copy link
Contributor

@lukhipolito-nexxbiz lukhipolito-nexxbiz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@sfmskywalker sfmskywalker merged commit 2f9eac1 into develop/3.6.0 Nov 21, 2025
3 checks passed
@sfmskywalker sfmskywalker deleted the chore/net10 branch November 21, 2025 19:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants