Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement missing features to enable compatibility with python's meshio #22

Closed
wants to merge 16 commits into from

Commits on Oct 1, 2022

  1. Configuration menu
    Copy the full SHA
    8ec027b View commit details
    Browse the repository at this point in the history
  2. Formatting lib.rs

    elrnv committed Oct 1, 2022
    Configuration menu
    Copy the full SHA
    2c9f439 View commit details
    Browse the repository at this point in the history
  3. Update legacy parser to work with offsets

    Added a parser for OFFSETS and CONNECTIVITY tags within legacy vtk files
    that mimic the way the xml file work.
    
    There is a new version of legacy vtk files (seemingly v5 and up) that
    specify cells via OFFSETS and CONNECTIVITY tags. This parser adds
    support for that.
    
    See issue #21 for exmaples.
    
    This commit addresses the parsing of the legacy files in that issue.
    elrnv committed Oct 1, 2022
    Configuration menu
    Copy the full SHA
    6c667f3 View commit details
    Browse the repository at this point in the history
  4. Added writing offsets style cells to legacy vtk

    Added the ability to write cells in new offsets + connectivity format
    for vtk versions 5+.
    
    See issue #21 for details.
    elrnv committed Oct 1, 2022
    Configuration menu
    Copy the full SHA
    79f0f03 View commit details
    Browse the repository at this point in the history
  5. Removed unnecessary write_u32_vec function

    Usage of this function is replaced by the generic write_vec function
    implemented in the previous commit.
    elrnv committed Oct 1, 2022
    Configuration menu
    Copy the full SHA
    1261fed View commit details
    Browse the repository at this point in the history
  6. Added .idea to .gitignore

    elrnv committed Oct 1, 2022
    Configuration menu
    Copy the full SHA
    78035fb View commit details
    Browse the repository at this point in the history
  7. Added assets/proto folder to gitignore

    This is where prototype assets can be stored which are used for
    temporary testing or large files that should not be committed to the
    repo.
    elrnv committed Oct 1, 2022
    Configuration menu
    Copy the full SHA
    d679737 View commit details
    Browse the repository at this point in the history
  8. Added testing for files generated by pygmsh/meshio

    This is taken from issue #21.
    
    All credit for these test files and gen.py script goes to @2pt0
    elrnv committed Oct 1, 2022
    Configuration menu
    Copy the full SHA
    f8be955 View commit details
    Browse the repository at this point in the history
  9. Cast cell types as integer when parsing xml

    Since some files can give non uint8 type cell types, we explicitly cast
    everything to the right type instead of expecting it to be given
    correctly. This helps parse files generated by meshio (See issue #21)
    elrnv committed Oct 1, 2022
    Configuration menu
    Copy the full SHA
    cfe3e28 View commit details
    Browse the repository at this point in the history
  10. Configuration menu
    Copy the full SHA
    b0271cd View commit details
    Browse the repository at this point in the history
  11. Configuration menu
    Copy the full SHA
    41249f2 View commit details
    Browse the repository at this point in the history
  12. Added a test for parsing new xml files from meshio

    One of the previous commits fixes the issue. This commit fixes the test for
    meshio generated files.
    elrnv committed Oct 1, 2022
    Configuration menu
    Copy the full SHA
    9c3bdf5 View commit details
    Browse the repository at this point in the history

Commits on Oct 2, 2022

  1. Update docs about VertexNumbers

    Clarify usage of xml and legacy formats, without renaming (yet).
    elrnv committed Oct 2, 2022
    Configuration menu
    Copy the full SHA
    3f8961c View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    aa4f672 View commit details
    Browse the repository at this point in the history
  3. Update default header_type to UInt32

    This makes the results more consistent with paraview.
    It also passes on one additional testcase from pygmsh.
    elrnv committed Oct 2, 2022
    Configuration menu
    Copy the full SHA
    b40f95b View commit details
    Browse the repository at this point in the history
  4. Implement compression support in DataArrays

    Each inline (non-appended) binary DataArray now supports compression in the
    same way appended data did before.
    
    This commit concludes fixes for all failing meshes from issue #21.
    
    The remaining pygmsh tests are now enabled.
    elrnv committed Oct 2, 2022
    Configuration menu
    Copy the full SHA
    2e9c3e9 View commit details
    Browse the repository at this point in the history