Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rfc89 sql logging callback implementation #1

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Rfc89 sql logging callback implementation #1

wants to merge 1 commit into from

Conversation

elpaso
Copy link
Owner

@elpaso elpaso commented Dec 2, 2022

TODO: benchmarks

rouault
rouault reviewed Dec 2, 2022
View reviewed changes
rouault
rouault reviewed Dec 12, 2022
View reviewed changes
autotest/cpp/test_ogr.cpp Outdated
@@ -34,6 +34,9 @@
#include "ogr_recordbatch.h"

#include <string>
#include <algorithm>
#include <filesystem>
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is C++17. We stick to C++11 for now in GDAL

gcore/gdaldataset.cpp
@@ -7514,6 +7514,11 @@ void GDALDataset::ShareLockWithParentDataset(GDALDataset* poParentDataset)
}
}

bool GDALDataset::SetQueryLoggerFunc(CPL_UNUSED GDALQueryLoggerFunc callback, CPL_UNUSED void* context )
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doxygen comments to add

ogr/ogrsf_frmts/gpkg/ogrgeopackagedatasource.cpp
static_cast<int>(osSQLCommandTruncated.size()),
&hSQLStmt, nullptr );

if( rc != SQLITE_OK )
{
{
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

extra whitespace

@elpaso elpaso force-pushed the rfc89_sql_logging_callback_implementation branch from 7f87b3b to 51e233c Compare December 22, 2022 08:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rouault rouault rouault left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@elpaso @rouault