Skip to content

Fixes #103 Html.map + blur event on DOM removal makes impossible states possible #166

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fixes #103 Html.map + blur event on DOM removal makes impossible states possible #166

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
02c0210
Fixes #103 Html.map + blur event on DOM removal makes impossible stat…
decioferreira Mar 4, 2020
de8f8f3
Fix case when no `Html.map` is used.
decioferreira Sep 1, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion src/Elm/Kernel/VirtualDom.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -574,6 +574,10 @@ function _VirtualDom_applyEvents(domNode, eventNode, events)
if (oldHandler.$ === newHandler.$)
{
oldCallback.__handler = newHandler;
oldCallback.__eventNode = eventNode.__tagger ? {
__tagger: eventNode.__tagger,
__parent: eventNode.__parent
} : eventNode;
continue;
}
domNode.removeEventListener(key, oldCallback);
Expand Down Expand Up @@ -633,7 +637,7 @@ function _VirtualDom_makeCallback(eventNode, initialHandler)
var currentEventNode = (
stopPropagation && event.stopPropagation(),
(tag == 2 ? value.b : tag == 3 && value.__$preventDefault) && event.preventDefault(),
eventNode
callback.__eventNode
);
var tagger;
var i;
Expand All @@ -656,6 +660,7 @@ function _VirtualDom_makeCallback(eventNode, initialHandler)
}

callback.__handler = initialHandler;
callback.__eventNode = eventNode.__tagger ? { __tagger: eventNode.__tagger, __parent: eventNode.__parent } : eventNode;

return callback;
}
Expand Down