Fix unicode escape decode bug in DoubleQuoteString example.
#22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously \u Unicode escape codes of between 4 and 6 characters were being rejected, whereas the error message indicates that the inverse should be the behavior. The example has also been extended to use all recognized escape sequences (\n, \r, \t, \u) and give more information about what's happening.
|
Very useful, thanks! @evancz please merge, this fixes an example and the output helps better understand what |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously
\uUnicode escape codes of between 4 and 6 characters were being rejected, whereas the error message indicates that the inverse should be the behavior.The example has also been extended to use all recognized escape sequences (
\n,\r,\t,\u) and give more information about what's happening.