Skip to content

Improve overall iteration performance #1000

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 9 commits into from
Closed

Improve overall iteration performance #1000

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
79b0673
Improve performance of String.reverse
Oct 24, 2018
a3e2594
Improve performance of String.map
Oct 24, 2018
a0d08c9
Fix accidental naming issue of __Utils_char
Oct 24, 2018
ff62fc5
Decrement i in the same line it is used
Oct 24, 2018
0387242
Convert decrementing while loops back to regular iterating ones
Oct 24, 2018
dc5f8c7
Fix naming issue again
Oct 24, 2018
ab9a85b
Convert other while loops to new pattern
Oct 24, 2018
b9f3151
Convert for-loop to new structure
Oct 24, 2018
c1944b8
Convert JsArray for-loops to use faster conditional
Oct 24, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 10 additions & 10 deletions src/Elm/Kernel/JsArray.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ var _JsArray_initialize = F3(function(size, offset, func)
{
var result = new Array(size);

for (var i = 0; i < size; i++)
for (var i = 0; size - i; i++)
{
result[i] = func(offset + i);
}
Expand All @@ -33,7 +33,7 @@ var _JsArray_initializeFromList = F2(function (max, ls)
{
var result = new Array(max);

for (var i = 0; i < max && ls.b; i++)
for (var i = 0; max - i && ls.b; i++)
{
result[i] = ls.a;
ls = ls.b;
Expand All @@ -53,7 +53,7 @@ var _JsArray_unsafeSet = F3(function(index, value, array)
var length = array.length;
var result = new Array(length);

for (var i = 0; i < length; i++)
for (var i = 0; length - i; i++)
{
result[i] = array[i];
}
Expand All @@ -67,7 +67,7 @@ var _JsArray_push = F2(function(value, array)
var length = array.length;
var result = new Array(length + 1);

for (var i = 0; i < length; i++)
for (var i = 0; length - i; i++)
{
result[i] = array[i];
}
Expand All @@ -80,7 +80,7 @@ var _JsArray_foldl = F3(function(func, acc, array)
{
var length = array.length;

for (var i = 0; i < length; i++)
for (var i = 0; length - i; i++)
{
acc = A2(func, array[i], acc);
}
Expand All @@ -90,7 +90,7 @@ var _JsArray_foldl = F3(function(func, acc, array)

var _JsArray_foldr = F3(function(func, acc, array)
{
for (var i = array.length - 1; i >= 0; i--)
for (var i = array.length; i--;)
{
acc = A2(func, array[i], acc);
}
Expand All @@ -103,7 +103,7 @@ var _JsArray_map = F2(function(func, array)
var length = array.length;
var result = new Array(length);

for (var i = 0; i < length; i++)
for (var i = 0; length - i; i++)
{
result[i] = func(array[i]);
}
Expand All @@ -116,7 +116,7 @@ var _JsArray_indexedMap = F3(function(func, offset, array)
var length = array.length;
var result = new Array(length);

for (var i = 0; i < length; i++)
for (var i = 0; length - i; i++)
{
result[i] = A2(func, offset + i, array[i]);
}
Expand All @@ -142,12 +142,12 @@ var _JsArray_appendN = F3(function(n, dest, source)
var size = destLen + itemsToCopy;
var result = new Array(size);

for (var i = 0; i < destLen; i++)
for (var i = 0; destLen - i; i++)
{
result[i] = dest[i];
}

for (var i = 0; i < itemsToCopy; i++)
for (var i = 0; itemsToCopy - i; i++)
{
result[i + destLen] = source[i];
}
Expand Down
11 changes: 6 additions & 5 deletions src/Elm/Kernel/String.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ var _String_map = F2(function(func, string)
var len = string.length;
var array = new Array(len);
var i = 0;
while (i < len)
while (len-i)
{
var word = string.charCodeAt(i);
if (0xD800 <= word && word <= 0xDBFF)
Expand All @@ -59,7 +59,7 @@ var _String_filter = F2(function(isGood, str)
var arr = [];
var len = str.length;
var i = 0;
while (i < len)
while (len-i)
{
var char = str[i];
var word = str.charCodeAt(i);
Expand All @@ -83,7 +83,7 @@ function _String_reverse(str)
var len = str.length;
var arr = new Array(len);
var i = 0;
while (i < len)
while (len-i)
{
var word = str.charCodeAt(i);
if (0xD800 <= word && word <= 0xDBFF)
Expand All @@ -106,7 +106,7 @@ var _String_foldl = F3(function(func, state, string)
{
var len = string.length;
var i = 0;
while (i < len)
while (len-i)
{
var char = string[i];
var word = string.charCodeAt(i);
Expand Down Expand Up @@ -280,8 +280,9 @@ function _String_toInt(str)
var total = 0;
var code0 = str.charCodeAt(0);
var start = code0 == 0x2B /* + */ || code0 == 0x2D /* - */ ? 1 : 0;
var len = str.length;

for (var i = start; i < str.length; ++i)
for (var i = start; len - i; ++i)
{
var code = str.charCodeAt(i);
if (code < 0x30 || 0x39 < code)
Expand Down