Decoding long strings can lead to large heap footprint #25
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… lot of 'concatenated string' elements on the heap, and consumes a lot more memory than a simple string needs. Using array.join to create the string avoids this.
|
This might not yet be the most efficient way of doing this, but does solve the big problem of using way too much memory. TextDecoder looks like it could work well, particularly for longer Strings, but will break Internet Explorer compatability (do we care??). Its unclear what the most efficient solution is without doing some benchmarking anyway. See https://github.com/gren-lang/core/blob/main/src/Gren/Kernel/Bytes.js#L34 for usage example of TextDecoder on bytes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes an issue where appending string char by char with += leads to a lot of 'concatenated string' elements on the heap, and consumes a lot more memory than a simple string needs. Using array.join to create the string avoids this.
#19