Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix null pointer as argument #90

Merged
merged 1 commit into from
Mar 9, 2021
Merged

Fix null pointer as argument #90

merged 1 commit into from
Mar 9, 2021

Conversation

razzeee
Copy link
Member

@razzeee razzeee commented Mar 7, 2021

Fuzzing did show two cases of undefined behavior. memcpy
can cause problems, so we'll use a loop instead.

Fixes #89

@razzeee
Copy link
Member Author

razzeee commented Mar 7, 2021

See https://stackoverflow.com/questions/5243012/is-it-guaranteed-to-be-safe-to-perform-memcpy0-0-0

@razzeee razzeee mentioned this pull request Mar 7, 2021
Closed
@razzeee razzeee force-pushed the fix-null-pointer-as-argument branch 2 times, most recently from a4c0b18 to 691b5a4 Compare March 7, 2021 01:41
harrysarson
harrysarson reviewed Mar 7, 2021
View reviewed changes
src/scanner.cc Outdated Show resolved Hide resolved
harrysarson
harrysarson reviewed Mar 7, 2021
View reviewed changes
src/scanner.cc Outdated Show resolved Hide resolved
@razzeee razzeee force-pushed the fix-null-pointer-as-argument branch from 9eb0acb to 1da8d3f Compare March 9, 2021 22:42
@razzeee
Fix null pointer as argument
5b2a115 
Fuzzing did show two cases of undefined behavior. memcpy
can cause problems, so we'll use a loop instead.

Fixes #89
@razzeee razzeee force-pushed the fix-null-pointer-as-argument branch from 1da8d3f to 5b2a115 Compare March 9, 2021 23:37
@razzeee razzeee merged commit 508f760 into master Mar 9, 2021
@razzeee razzeee deleted the fix-null-pointer-as-argument branch March 9, 2021 23:50
@razzeee razzeee mentioned this pull request Mar 10, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@harrysarson harrysarson harrysarson left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Undefined behavior
2 participants
@razzeee @harrysarson