fixes elm#21

fixes elm#22 Sanitize input to `float` to avoid invalid values
elm-janitor · Feb 17, 2023 · 0b9ad8b · 0b9ad8b
1 parent c1c9da4
commit 0b9ad8b
Showing 1 changed file with 9 additions and 2 deletions.
diff --git a/src/Random.elm b/src/Random.elm
@@ -156,6 +156,13 @@ float : Float -> Float -> Generator Float
 float a b =
     Generator (\seed0 ->
         let
+            -- Sanitize the input range
+            ( minRange, maxRange ) =
+                if a < b then
+                    ( a, b )
+                else
+                    ( b, a )
+
             -- Get 64 bits of randomness
             seed1 =
                 next seed0
@@ -179,10 +186,10 @@ float a b =
 
             -- Scale it into our range
             range =
-                abs (b - a)
+                abs (maxRange - minRange)
 
             scaled =
-                val * range + a
+                val * range + minRange
         in
             ( scaled, next seed1 )
         )