Merged
Conversation
harrysarson
approved these changes
Nov 17, 2020
drathier
reviewed
Nov 20, 2020
README.md
Outdated
|
|
||
| * [`travis.yml`](https://github.com/rtfeldman/elm-css/blob/master/.travis.yml) | ||
| * [`appveyor.yml`](https://github.com/rtfeldman/elm-css/blob/master/appveyor.yml) | ||
| Head over to the [CLI test runner](https://github.com/rtfeldman/node-test-runner) for instructions on how to get started! |
Collaborator
There was a problem hiding this comment.
I'd like a short paragraph/sentence explaining that this is the test library which you use to write tests, and that you need a test runner such as node-test-runner to actually run the tests. There are more than one test runner, so I wouldn't want to talk about it as the test runner, even though it's the most popular one now by far.
Contributor
Author
There was a problem hiding this comment.
👍
Out of curiosity, are there more runners than https://github.com/rtfeldman/node-test-runner and https://github.com/mpizenberg/elm-test-rs ?
Collaborator
There was a problem hiding this comment.
Yes, I know of a private closed source test runner
Collaborator
|
LGTM, thanks! |
harrysarson
pushed a commit
to rtfeldman/node-test-runner
that referenced
this pull request
Jan 20, 2021
- Recommend installing locally. Fixes #249. - Move more common flags first, both in the readme and in `--help`. - Sync the descriptions between the readme and `--help`. - Try to explain the difference between node-test-runner and elm-explorations/test. - Document where to put your tests. - Various other little tweaks to try to be more helpful. PR for elm-explorations/test: elm-explorations/test#160 We should also update the repo description because it currently says: > Runs elm-test suites from Node.js. Get it with npm install -g elm-test
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Leave the node-test-runner installation and usage instructions to node-test-runner’s readme.
Together with rtfeldman/node-test-runner#473, this fixes rtfeldman/node-test-runner#249.