Prevent values like -0 in xdot output #1177
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Two graphs in the shapes regression test reference files (invhouse and invtrapezium) contained a -0 coordinate. The Linux build produced the same results, but the Windows build didn't, causing the regression tests to fail. To prevent values like -0 in the xdot output, a comparison is added just before formatting the number.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Two graphs in the shapes regression test reference files (invhouse and
invtrapezium) contained a -0 coordinate. The Linux build produced the same
results, but the Windows build didn't, causing the regression tests to
fail.
To prevent values like -0 in the xdot output, a comparison is added just
before formatting the number.
I used the same comparison as I did before (but with a smaller value).
Is this a good method for now?