Skip to content

Update rush-project.json schema. #7

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 11 additions & 19 deletions rigs/acme-classic-rig/profiles/library/config/rush-project.json
Original file line number Diff line number Diff line change
@@ -1,38 +1,30 @@
{
// This list still exists for non-phased bulk commands.
//
// Note that although in THIS case, this list is equal to or are parents
// of all the folders below in the phaseOptions list, but that's not required
// (this list is only used for non-phased build commands, and the below options
// are only used for phased build commands).
"projectOutputFolderNames": ["lib", "lib-commonjs", "dist", "temp"],

// Structure proposed by @octogonz for phase options
//
// Folders like "temp/coverage" are (probably) already folders written to by
// your unit tests, while folders like "temp/lint" are possible places we could
// have phases write their log outputs to (since the phase is likely not to have
// any other tangible output files to cache).
"phaseOptions": [
"operationSettings": [
{
"phaseName": "_phase:compile",
"projectOutputFolderNames": ["lib", "lib-commonjs", "dist", "temp/compile"]
"operationName": "_phase:compile",
"outputFolderNames": ["lib", "lib-commonjs", "dist", "temp/compile"]
},
{
"phaseName": "_phase:lint",
"projectOutputFolderNames": ["temp/lint"]
"operationName": "_phase:lint",
"outputFolderNames": ["temp/lint"]
},
{
"phaseName": "_phase:test",
"projectOutputFolderNames": ["temp/test", "temp/jest-reports", "temp/coverage"]
"operationName": "_phase:test",
"outputFolderNames": ["temp/test", "temp/jest-reports", "temp/coverage"]
},
{
"phaseName": "_phase:update-readme",
"projectOutputFolderNames": ["temp/update-readme"]
"operationName": "_phase:update-readme",
"outputFolderNames": ["temp/update-readme"]
},
{
"phaseName": "_phase:push-notes",
"projectOutputFolderNames": ["temp/push-notes"]
"operationName": "_phase:push-notes",
"outputFolderNames": ["temp/push-notes"]
}
]
}
30 changes: 11 additions & 19 deletions rigs/acme-classic-rig/profiles/web-app/config/rush-project.json
Original file line number Diff line number Diff line change
@@ -1,38 +1,30 @@
{
// This list still exists for non-phased bulk commands.
//
// Note that although in THIS case, this list is equal to or are parents
// of all the folders below in the phaseOptions list, but that's not required
// (this list is only used for non-phased build commands, and the below options
// are only used for phased build commands).
"projectOutputFolderNames": ["lib", "lib-commonjs", "dist", "temp"],

// Structure proposed by @octogonz for phase options
//
// Folders like "temp/coverage" are (probably) already folders written to by
// your unit tests, while folders like "temp/lint" are possible places we could
// have phases write their log outputs to (since the phase is likely not to have
// any other tangible output files to cache).
"phaseOptions": [
"operationSettings": [
{
"phaseName": "_phase:compile",
"projectOutputFolderNames": ["lib", "lib-commonjs", "dist", "temp/compile"]
"operationName": "_phase:compile",
"outputFolderNames": ["lib", "lib-commonjs", "dist", "temp/compile"]
},
{
"phaseName": "_phase:lint",
"projectOutputFolderNames": ["temp/lint"]
"operationName": "_phase:lint",
"outputFolderNames": ["temp/lint"]
},
{
"phaseName": "_phase:test",
"projectOutputFolderNames": ["temp/test", "temp/jest-reports", "temp/coverage"]
"operationName": "_phase:test",
"outputFolderNames": ["temp/test", "temp/jest-reports", "temp/coverage"]
},
{
"phaseName": "_phase:update-readme",
"projectOutputFolderNames": ["temp/update-readme"]
"operationName": "_phase:update-readme",
"outputFolderNames": ["temp/update-readme"]
},
{
"phaseName": "_phase:push-notes",
"projectOutputFolderNames": ["temp/push-notes"]
"operationName": "_phase:push-notes",
"outputFolderNames": ["temp/push-notes"]
}
]
}