Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: update design of square avatar #808

Merged
merged 1 commit into from
Jan 5, 2023
Merged

Conversation

wheatjs
Copy link
Member

@wheatjs wheatjs commented Jan 5, 2023

Before
image

After:
image

One concern I have is this method requires using clip-mask so we need an svg with a clipPath. Since we can only have one id per document I put it in app.vue, but I'm not sure if this is the best location for it. If you have any ideas on where it would better fit lmk.

@stackblitz
Copy link

stackblitz bot commented Jan 5, 2023

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@netlify
Copy link

netlify bot commented Jan 5, 2023

Deploy Preview for elk-zone ready!

Name Link
🔨 Latest commit 9daae03
🔍 Latest deploy log https://app.netlify.com/sites/elk-zone/deploys/63b74afa201ef400080b4935
😎 Deploy Preview https://deploy-preview-808--elk-zone.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

Copy link
Member

@patak-dev patak-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So much more playful... I think we should merge and see how it works for others during the next few days.

@patak-dev patak-dev merged commit a35884c into main Jan 5, 2023
@patak-dev patak-dev deleted the feat/square-avatar-mask branch January 5, 2023 22:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants