fix: type errors #802
Merged
fix: type errors #802
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
✅ Deploy Preview for elk-zone ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
sxzz
force-pushed
the
refactor/type-errors
branch
from
d3db4ae
to
5b9a85b
Compare
sxzz
force-pushed
the
refactor/type-errors
branch
from
5b9a85b
to
1fff9bd
Compare
sxzz
added
the
c: refactor
edimitchel
reviewed
Jan 5, 2023
| @@ -15,7 +16,7 @@ const { translation } = useTranslation(status) | |||
| class="line-compact" | |||
| :content="status.content" | |||
| :emojis="status.emojis" | |||
| :lang="status.language" | |||
| :lang="'language' in status && status.language" | |||
There was a problem hiding this comment.
Suggested change
| :lang="'language' in status && status.language" | |
| :lang="status?.language" |
?
There was a problem hiding this comment.
Can't do that. TS will emit an erorr
antfu
approved these changes
Jan 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I removed
html.d.tssince this file marks all props as any and fixes all TS errors.I asked Johnson and
html.d.tsis no longer necessary with the latest Volar /cc @antfuThe main purpose of this PR is to fix TS errors, but I think we should refactor code of search scope. I'll do it in another PR.