Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: glob for emojis cache for pwa #729

Merged
merged 1 commit into from
Jan 3, 2023
Merged

Conversation

cyberalien
Copy link
Member

Fixes typo in glob pattern that caused PWA to cache all emojis.

@stackblitz
Copy link

stackblitz bot commented Jan 3, 2023

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@netlify
Copy link

netlify bot commented Jan 3, 2023

Deploy Preview for elk-zone ready!

Name Link
🔨 Latest commit 880b4dd
🔍 Latest deploy log https://app.netlify.com/sites/elk-zone/deploys/63b3f97fd29aa30008b93d5b
😎 Deploy Preview https://deploy-preview-729--elk-zone.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@cyberalien
Copy link
Member Author

Sorry, previous emoji related pr should have been marked as draft and this commit should have been part of it, before it was merged.

This pr is ready.

@patak-dev
Copy link
Member

Sorry I merged it without @userquin approval 🙏🏼
Thanks for the fix

@patak-dev patak-dev merged commit 177df4a into main Jan 3, 2023
@patak-dev patak-dev deleted the cyberalien/pwa-emoji-glob branch January 3, 2023 09:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants