Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add account field icon for 'Language(s)' #720

Merged
merged 1 commit into from
Jan 3, 2023
Merged

Conversation

linusg
Copy link
Contributor

@linusg linusg commented Jan 2, 2023

This is useful for people posting in multiple languages on their account, which many people would list under a "Languages" metadata entry.

Before:
image

After:
image

@stackblitz
Copy link

stackblitz bot commented Jan 2, 2023

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@netlify
Copy link

netlify bot commented Jan 2, 2023

Deploy Preview for elk-zone ready!

Name Link
🔨 Latest commit 4247b08
🔍 Latest deploy log https://app.netlify.com/sites/elk-zone/deploys/63b3689b149d2c000859063b
😎 Deploy Preview https://deploy-preview-720--elk-zone.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

composables/icons.ts Outdated Show resolved Hide resolved
@sxzz
Copy link
Member

sxzz commented Jan 2, 2023

I suggest to use singular form
and change the icon to
image

@linusg linusg changed the title feat: add account field icon for 'Languages' feat: add account field icon for 'Language(s)' Jan 2, 2023
@sxzz sxzz merged commit 8a3cfcd into main Jan 3, 2023
@sxzz sxzz deleted the account-field-languages branch January 3, 2023 00:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants