Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allow searching for statuses #632

Merged
merged 1 commit into from
Dec 29, 2022
Merged

feat: allow searching for statuses #632

merged 1 commit into from
Dec 29, 2022

Conversation

danielroe
Copy link
Member

resolves #520

Note that I'm also now hiding the 'three dot' action menu when we are hiding actions. If this isn't sensible we can add another prop - may be worth doing this anyway.

@danielroe danielroe added the c: feature Request for new feature label Dec 29, 2022
@danielroe danielroe self-assigned this Dec 29, 2022
@stackblitz
Copy link

stackblitz bot commented Dec 29, 2022

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@netlify
Copy link

netlify bot commented Dec 29, 2022

Deploy Preview for elk-zone ready!

Name Link
🔨 Latest commit f18a887
🔍 Latest deploy log https://app.netlify.com/sites/elk-zone/deploys/63ada4c17efbb400084acf73
😎 Deploy Preview https://deploy-preview-632--elk-zone.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

Copy link
Member

@patak-dev patak-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It works great! Let's merge and iterate. Maybe we could strip the elk.zone/ deployment URL so these could also be searchable? Right now, if you go to copy URL in status, you get the version prefixed, which doesn't yet work in the search bar.

@patak-dev patak-dev merged commit 12280af into main Dec 29, 2022
@patak-dev patak-dev deleted the feat/search-urls branch December 29, 2022 14:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c: feature Request for new feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Searching by an URL of a post should show the post
2 participants