Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: autoplay video only when on screen #624

Merged
merged 2 commits into from
Dec 28, 2022

Conversation

userquin
Copy link
Member

@userquin userquin commented Dec 28, 2022

Maybe we can reduce the threshold, if the video is largen than screen will not autoplay...

Maybe we can reduce it to 0.75 or 0.85.

@stackblitz
Copy link

stackblitz bot commented Dec 28, 2022

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@netlify
Copy link

netlify bot commented Dec 28, 2022

Deploy Preview for elk-zone ready!

Name Link
🔨 Latest commit 96e1ca7
🔍 Latest deploy log https://app.netlify.com/sites/elk-zone/deploys/63accb37fdd4d70008450102
😎 Deploy Preview https://deploy-preview-624--elk-zone.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

Copy link
Member

@patak-dev patak-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@patak-dev patak-dev merged commit 121c90f into main Dec 28, 2022
@patak-dev patak-dev deleted the userquin/fix-auto-play-iobserver-callback branch December 28, 2022 23:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants