-
-
Notifications
You must be signed in to change notification settings - Fork 565
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: replace emoji with SVGs (#129) #584
Conversation
Run & review this pull request in StackBlitz Codeflow. |
✅ Deploy Preview for elk-zone ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
Bugs:
|
Fixed first bug in a dependency. |
Fixed issue with editing drafts. So I think this is usable now. No bugs that I can see. Switching emoji sets for now requires changing dependency, in future I want to create an easy to use workflow that would allow quickly changing emoji set without much effort, add/replace custom emoji (unicode emojis, not |
Fixed #667 Old code failed at this sequence, which was mentioned in another issue:
GitHub seems to fail at parsing it too, click button to quote this reply to see correct emoji as raw text without GitHub replacement. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is awesome! Thanks a lot for your effort! 🔥
I will figure out how to replace the ones on EmojiMarket later.
Replaces emojis with SVGs.
Emoji sets can be replaced by changing dependency in
config/emoji.ts
.Currently available emoji sets:
@iconify-emoji/twemoji
- Twitter Emoji, used by default@iconify-emoji/openmoji
- OpenMoji@iconify-emoji/noto
- Noto Emoji by Google@iconify-emoji/fluent-emoji-flat
- Fluent Emoji (only "Flat" version for now) by MicrosoftTo switch set, install appropriate package as dependency, change it in
config/emoji.ts
and runprepare
script that will copy all files.Emojis are copied to
public/emojis/${prefix}/
, which is ignored in.gitignore
.There probably are bugs, creation of various emoji packages is not automated yet.