feat: render custom server emojis on editor #579
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
✅ Deploy Preview for elk-zone ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
antfu
reviewed
Dec 27, 2022
composables/content-parse.ts
Outdated
| @@ -1,6 +1,7 @@ | |||
| import type { Emoji } from 'masto' | |||
| import type { Node } from 'ultrahtml' | |||
| import { TEXT_NODE, parse, render, walkSync } from 'ultrahtml' | |||
| import { currentCustomEmojisObject } from '~/composables/emojis' | |||
There was a problem hiding this comment.
This moudle should avoid referenceing any runtime logic to keep the function pure.
There was a problem hiding this comment.
ok, I'll move logic to ContentRich.setup.ts module, but the registry will be on each instance...
There was a problem hiding this comment.
when we receive custom emojis from another server: check the video on elk editor room
userquin
commented
Dec 27, 2022
| /** | ||
| * Add an emoji. | ||
| */ | ||
| setEmoji: (options: { src: string; alt?: string; title?: string }) => ReturnType |
There was a problem hiding this comment.
should add width, height and data-emoji-id here
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is a custom extension for
@tiptap/extension-image(doesn't support set custom attrs on the image).Added checking custom server emojis stored on local storage when parsing html.