Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

perf: reduce timeline limit on slow connection #2945

Merged
merged 1 commit into from
Sep 7, 2024
Merged

perf: reduce timeline limit on slow connection #2945

merged 1 commit into from
Sep 7, 2024

Conversation

Shinigami92
Copy link
Member

@Shinigami92 Shinigami92 commented Sep 6, 2024 •
edited
Loading

This reduces the limit for timeline post to 10 when used on slow connection

with this change:
image

without this change:
image

@Shinigami92 Shinigami92 self-assigned this Sep 6, 2024
@netlify Netlify
Copy link

netlify bot commented Sep 6, 2024 •
edited
Loading

✅ Deploy Preview for elk-docs canceled.

Name Link
🔨 Latest commit 91bbd36
🔍 Latest deploy log https://app.netlify.com/sites/elk-docs/deploys/66db486e0afc72000816408d

@netlify Netlify
Copy link

netlify bot commented Sep 6, 2024 •
edited
Loading

✅ Deploy Preview for elk-zone ready!

Name Link
🔨 Latest commit 91bbd36
🔍 Latest deploy log https://app.netlify.com/sites/elk-zone/deploys/66db486e2e5dc200082fc46f
😎 Deploy Preview https://deploy-preview-2945--elk-zone.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@Shinigami92 Shinigami92 added the c: performance Related to performance label Sep 6, 2024
@Shinigami92 Shinigami92 marked this pull request as ready for review September 6, 2024 18:34
shuuji3
shuuji3 approved these changes Sep 7, 2024
View reviewed changes
Copy link
Member

@shuuji3 shuuji3 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice improvement👍🏻 Confirmed the count of posts is changed by switching to a 3G network on DevTools.

@shuuji3 shuuji3 added this pull request to the merge queue Sep 7, 2024
Merged via the queue into main with commit 4caa63e Sep 7, 2024
16 checks passed
@shuuji3 shuuji3 deleted the perf-reduce-timeline-on-slow-connection branch September 7, 2024 09:29
shuuji3 pushed a commit that referenced this pull request Oct 21, 2024
@Shinigami92 @shuuji3
perf: reduce timeline limit on slow connection (#2945)
12dab34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shuuji3 shuuji3 shuuji3 approved these changes

Assignees

@Shinigami92 Shinigami92

Labels
c: performance Related to performance
Projects
Elk Roadmap
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Shinigami92 @shuuji3