-
-
Notifications
You must be signed in to change notification settings - Fork 565
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(ui): profile name gets cut off by roles #2915
fix(ui): profile name gets cut off by roles #2915
Conversation
✅ Deploy Preview for elk-docs canceled.
|
✅ Deploy Preview for elk-zone ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Update - I just realized the AccountInfo card only shows 1 role. So, my comment about this being a "list of roles" doesn't apply. I am also noticing the Elk preview link does not show any roles at all, no matter where they show in the app. Not sure why that is. |
If I remember correctly, you'd only see roles if the profile is viewed in the oroginal server, and maybe the preview deployment is in a different server than your account. |
I think the idea was for the profile to be consistent in different views. I'm not against moving the role chip down to prevent the name getting cut but maybe we should do that everywhere if we do it. |
Sure. So, if Elk went with this UI update, profile styling across all locations in the app would be:
I pushed a commit to remove the code that shows the profile roles inline on the hover card. I also updated the profile page to make name + username + role order consistent with everywhere else that the profile is shown. If we use this order, it gives the profile page room to show a full list of roles without the username getting pushed down. This is also the order that Mastodon uses. |
I'm not specifically against putting the roles inline, it does vibe with Elk wanting to make the UI feel cleaner and more space efficient. For a UI comparison, GitHub has a pretty clean hover card for profiles, with display name and pronouns inline. At the end of the day, I'm just interested in fixing the profile UI at the bottom-left. So, another alternative could be to just not show the roles at the bottom-left. It's not a public-facing part of the UI (compared to the profile page), and it's meant to tell the user what account they're logged into, rather than educate the user about their account. It could be argued that omitting roles from this UI would not confuse users too much, and on the consistency side, this would allow Elk to keep the inline roles everywhere else. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am good with the change. We could figure out a better design later (if ever need), consider this is more like a fix, I think we could have it and move on first.
Description
Fixes the UI issue with the profile name getting cut off when the user has roles.
On the bottom-left profile card, the roles UI was moved to be below the username.
It could be in-between the name and username, but because this is a list of roles, for some users that list would look better as the last list item.
Minor tweaks
For this taller profile info card, the avatar was centered.
AccountHoverCard.vue
originally was not using thehoverCard
prop onAccountInfo.vue
, this was added since the hover card has the space to show roles inline with the profile name.Screenshots
Before:
After:
The hover card remains untouched since it has the extra space:
Mobile:
Multiple users:
Misc
fixes: #2914