fix(ui): fix and adjust bottom navigation preview on setting page #2818
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
✅ Deploy Preview for elk-docs canceled.
|
✅ Deploy Preview for elk-zone ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
ayoayco
approved these changes
Aug 10, 2024
|
Changes look good 👍 |
shuuji3
force-pushed
the
shuuji3/fix/setting-interface-bottom-navigation-style
branch
from
9164f38
to
2217dd6
Compare
|
Thanks for the review! I just resolved the code conflict. |
shuuji3
force-pushed
the
shuuji3/fix/setting-interface-bottom-navigation-style
branch
from
2217dd6
to
8c04702
Compare
|
Let me self-merge this as Ayo has already reviewed and this is just a small style adjustment. |
shuuji3
deleted the
shuuji3/fix/setting-interface-bottom-navigation-style
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #2805
Adjusted spacing for a narrow viewport.
Also, I removed
<button>-related attributes since we don't need to click the button in the preview.Screenshot
Before
After